Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: content/browser/devtools/protocol/service_worker_handler.cc

Issue 1102263002: Add skipWaiting checkbox to ServiceWorkersView in DevTools [1/2 chromium] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/service_worker_handler.cc
diff --git a/content/browser/devtools/protocol/service_worker_handler.cc b/content/browser/devtools/protocol/service_worker_handler.cc
index 6f426f4037da17c5f59d117dd3debf1e5d4d8d0a..93e6cceb975c7101df2290986ff6aa589db22a50 100644
--- a/content/browser/devtools/protocol/service_worker_handler.cc
+++ b/content/browser/devtools/protocol/service_worker_handler.cc
@@ -356,6 +356,19 @@ Response ServiceWorkerHandler::InspectWorker(const std::string& version_id) {
return Response::OK();
}
+Response ServiceWorkerHandler::SkipWaiting(const std::string& version_id) {
+ if (!enabled_)
+ return Response::OK();
+ if (!context_)
+ return CreateContextErrorResoponse();
falken 2015/04/28 02:01:14 typo: Response
horo 2015/04/28 02:13:25 Done.
+
+ int64 id = 0;
+ if (!base::StringToInt64(version_id, &id))
+ return CreateInvalidVersionIdErrorResoponse();
falken 2015/04/28 02:01:14 typo: Response
horo 2015/04/28 02:13:25 Done.
+ context_->SimulateSkipWaiting(id);
+ return Response::OK();
+}
+
Response ServiceWorkerHandler::SetDebugOnStart(bool debug_on_start) {
ServiceWorkerDevToolsManager::GetInstance()
->set_debug_service_worker_on_start(debug_on_start);

Powered by Google App Engine
This is Rietveld 408576698