Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1102263002: Add skipWaiting checkbox to ServiceWorkersView in DevTools [1/2 chromium] (Closed)

Created:
5 years, 8 months ago by horo
Modified:
5 years, 7 months ago
Reviewers:
falken, pfeldman
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, tzik, horo+watch_chromium.org, jam, yurys, darin-cc_chromium.org, nhiroki, devtools-reviews_chromium.org, kinuko+serviceworker, kinuko+watch, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add skipWaiting checkbox to ServiceWorkersView in DevTools [1/2 chromium] 1/2 chromium: this cl 2/2 blink: https://codereview.chromium.org/1100403004/ screen shot: https://code.google.com/p/chromium/issues/detail?id=466871#c61 BUG=466871 Committed: https://crrev.com/79b525b022f9a1ec5a5ee893d160cc90fe6c1a70 Cr-Commit-Position: refs/heads/master@{#327227}

Patch Set 1 #

Total comments: 4

Patch Set 2 : s/Resoponse/Response/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -11 lines) Patch
M content/browser/devtools/protocol/service_worker_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 1 8 chunks +24 lines, -11 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
horo
falken@ Could you please review this?
5 years, 8 months ago (2015-04-27 12:52:16 UTC) #2
pfeldman
lgtm
5 years, 8 months ago (2015-04-27 16:45:47 UTC) #4
falken
looks good, but is it possible to add a test? https://codereview.chromium.org/1102263002/diff/1/content/browser/devtools/protocol/service_worker_handler.cc File content/browser/devtools/protocol/service_worker_handler.cc (right): https://codereview.chromium.org/1102263002/diff/1/content/browser/devtools/protocol/service_worker_handler.cc#newcode363 ...
5 years, 7 months ago (2015-04-28 02:01:15 UTC) #5
horo
> looks good, but is it possible to add a test? Yes. I will add ...
5 years, 7 months ago (2015-04-28 02:13:25 UTC) #6
falken
thanks, lgtm
5 years, 7 months ago (2015-04-28 02:14:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102263002/20001
5 years, 7 months ago (2015-04-28 02:19:20 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-28 03:08:56 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 03:09:40 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/79b525b022f9a1ec5a5ee893d160cc90fe6c1a70
Cr-Commit-Position: refs/heads/master@{#327227}

Powered by Google App Engine
This is Rietveld 408576698