Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 1102193002: Remove NOTIFICATION_EXTENSIONS_READY from ephemeral_app_service.cc (Closed)

Created:
5 years, 8 months ago by limasdf
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NOTIFICATION_EXTENSIONS_READY from ephemeral_app_service.cc Use ExtensionSystem::Ready instead of NOTIFICATION_EXTENSIONS_READY. R=kalman@chromium.org BUG=354459 Committed: https://crrev.com/172214038410fb835cc36721fcc2dc7b7a7dd5fd Cr-Commit-Position: refs/heads/master@{#327171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -32 lines) Patch
M chrome/browser/apps/ephemeral_app_service.h View 5 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_service.cc View 3 chunks +4 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
limasdf
5 years, 8 months ago (2015-04-26 10:49:59 UTC) #2
not at google - send to devlin
lgtm
5 years, 8 months ago (2015-04-27 20:12:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102193002/1
5 years, 8 months ago (2015-04-27 21:48:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 23:21:49 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 23:22:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/172214038410fb835cc36721fcc2dc7b7a7dd5fd
Cr-Commit-Position: refs/heads/master@{#327171}

Powered by Google App Engine
This is Rietveld 408576698