Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: components/guest_view/browser/guest_view_manager_delegate.h

Issue 1102173002: Move GuestView layer in browser to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Mac Build + GN Test builds Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/browser/guest_view_manager_delegate.h
diff --git a/extensions/browser/guest_view/guest_view_manager_delegate.h b/components/guest_view/browser/guest_view_manager_delegate.h
similarity index 69%
rename from extensions/browser/guest_view/guest_view_manager_delegate.h
rename to components/guest_view/browser/guest_view_manager_delegate.h
index f6e1795fb86c931bf7537e31fd19e66b18f81d71..b225ab9e85079b49283352eb45fcc3670357deb0 100644
--- a/extensions/browser/guest_view/guest_view_manager_delegate.h
+++ b/components/guest_view/browser/guest_view_manager_delegate.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_DELEGATE_H_
-#define EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_DELEGATE_H_
+#ifndef COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_MANAGER_DELEGATE_H_
+#define COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_MANAGER_DELEGATE_H_
#include <string>
@@ -13,12 +13,10 @@ namespace base {
class DictionaryValue;
} // namespace base
-namespace extensions {
-class GuestViewBase;
-} // namespace extensions
-
namespace guestview {
+class GuestViewBase;
+
// A GuestViewManagerDelegate interface allows GuestViewManager to delegate
// responsibilities to other modules in Chromium. Different builds of Chromium
// may use different GuestViewManagerDelegate implementations. For example,
@@ -27,27 +25,28 @@ namespace guestview {
// return false.
class GuestViewManagerDelegate {
public:
- virtual ~GuestViewManagerDelegate() {}
+ GuestViewManagerDelegate();
+ virtual ~GuestViewManagerDelegate();
// Dispatches the event with |name| with the provided |args| to the embedder
// of the given |guest| with |instance_id| for routing.
virtual void DispatchEvent(const std::string& event_name,
scoped_ptr<base::DictionaryValue> args,
- extensions::GuestViewBase* guest,
- int instance_id) = 0;
+ GuestViewBase* guest,
+ int instance_id) {}
// Indicates whether the |guest| can be used within the context of where it
// was created.
- virtual bool IsGuestAvailableToContext(extensions::GuestViewBase* guest) = 0;
+ virtual bool IsGuestAvailableToContext(GuestViewBase* guest);
// Indicates whether the |guest| is owned by an extension or Chrome App.
- virtual bool IsOwnedByExtension(extensions::GuestViewBase* guest) = 0;
+ virtual bool IsOwnedByExtension(GuestViewBase* guest);
// Registers additional GuestView types the delegator (GuestViewManger) can
// create.
- virtual void RegisterAdditionalGuestViewTypes() = 0;
+ virtual void RegisterAdditionalGuestViewTypes() {}
};
} // namespace guestview
-#endif // EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_DELEGATE_H_
+#endif // COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_MANAGER_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698