extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc - Issue 1102173002: Move GuestView layer in browser to components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Issue 1102173002: Move GuestView layer in browser to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed John's comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/guest_view/guest_view_container.cc ('k') | extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

index 2310d3dcbc92255798d27d5a080172246f78ee5b..9f8d952632ac2bd510a642e7c9399192dacc97e4 100644

--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

@@ -7,11 +7,11 @@

#include <string>

#include "base/bind.h"

+#include "components/guest_view/common/guest_view_constants.h"

#include "content/public/child/v8_value_converter.h"

#include "content/public/renderer/render_view.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_messages.h"

-#include "extensions/common/guest_view/guest_view_constants.h"

#include "extensions/renderer/guest_view/extensions_guest_view_container.h"

#include "extensions/renderer/script_context.h"

#include "third_party/WebKit/public/web/WebFrame.h"

@@ -87,7 +87,7 @@ void GuestViewInternalCustomBindings::AttachGuest(

// Add flag to |params| to indicate that the element size is specified in

// logical units.

- params->SetBoolean(guestview::kElementSizeIsLogical, true);

+ params->SetBoolean(guest_view::kElementSizeIsLogical, true);

linked_ptr<ExtensionsGuestViewContainer::Request> request(

new ExtensionsGuestViewContainer::AttachRequest(