Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

Issue 1102173002: Move GuestView layer in browser to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed John's comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
diff --git a/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
index 0d3c2b980cf9cd03774e073c4a726004fc196051..1ac3c848ac99cd8ab1b93c0fd500792e74498459 100644
--- a/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
+++ b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
@@ -6,11 +6,11 @@
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
+#include "components/guest_view/common/guest_view_constants.h"
#include "extensions/browser/guest_view/web_view/web_view_constants.h"
#include "extensions/browser/guest_view/web_view/web_view_guest.h"
#include "extensions/browser/guest_view/web_view/web_view_permission_helper.h"
#include "extensions/browser/guest_view/web_view/web_view_permission_types.h"
-#include "extensions/common/guest_view/guest_view_constants.h"
namespace extensions {
@@ -58,7 +58,7 @@ void JavaScriptDialogHelper::RunJavaScriptDialog(
request_info.Set(webview::kMessageType,
new base::StringValue(
JavaScriptMessageTypeToString(javascript_message_type)));
- request_info.Set(guestview::kUrl, new base::StringValue(origin_url.spec()));
+ request_info.Set(guest_view::kUrl, new base::StringValue(origin_url.spec()));
WebViewPermissionHelper* web_view_permission_helper =
WebViewPermissionHelper::FromWebContents(web_contents);
web_view_permission_helper->RequestPermission(
« no previous file with comments | « extensions/browser/guest_view/test_guest_view_manager.cc ('k') | extensions/browser/guest_view/web_view/web_view_apitest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698