extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc - Issue 1102173002: Move GuestView layer in browser to components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

Issue 1102173002: Move GuestView layer in browser to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed John's comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h ('k') | extensions/browser/guest_view/surface_worker/surface_worker_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

index bf91ebe499b5ba693780544d4612ccfd34407e7f..61fd14276bb5dc7fcdd404b985c47deaa86e0c22 100644

--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

@@ -5,6 +5,7 @@

#include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h"

#include "base/strings/stringprintf.h"

+#include "components/guest_view/common/guest_view_constants.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/host_zoom_map.h"

#include "content/public/browser/render_process_host.h"

@@ -22,13 +23,13 @@

#include "extensions/common/constants.h"

#include "extensions/common/extension_messages.h"

#include "extensions/common/guest_view/extensions_guest_view_messages.h"

-#include "extensions/common/guest_view/guest_view_constants.h"

#include "extensions/strings/grit/extensions_strings.h"

#include "ipc/ipc_message_macros.h"

#include "net/base/url_util.h"

#include "third_party/WebKit/public/web/WebInputEvent.h"

using content::WebContents;

+using guest_view::GuestViewBase;

namespace extensions {