Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

Issue 1102173002: Move GuestView layer in browser to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed John's comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
index 916dcd0a7afa6201e80f092cdc1064762d96ee9b..3e6eaa13957a1a3e8a203944251233fcf056b3f1 100644
--- a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
+++ b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
@@ -132,7 +132,7 @@ void ChromeWebViewPermissionHelperDelegate::CanDownload(
const std::string& request_method,
const base::Callback<void(bool)>& callback) {
base::DictionaryValue request_info;
- request_info.SetString(guestview::kUrl, url.spec());
+ request_info.SetString(guest_view::kUrl, url.spec());
web_view_permission_helper()->RequestPermission(
WEB_VIEW_PERMISSION_TYPE_DOWNLOAD,
request_info,
@@ -155,10 +155,10 @@ void ChromeWebViewPermissionHelperDelegate::RequestPointerLockPermission(
bool last_unlocked_by_target,
const base::Callback<void(bool)>& callback) {
base::DictionaryValue request_info;
- request_info.SetBoolean(guestview::kUserGesture, user_gesture);
+ request_info.SetBoolean(guest_view::kUserGesture, user_gesture);
request_info.SetBoolean(webview::kLastUnlockedBySelf,
last_unlocked_by_target);
- request_info.SetString(guestview::kUrl,
+ request_info.SetString(guest_view::kUrl,
web_contents()->GetLastCommittedURL().spec());
web_view_permission_helper()->RequestPermission(
@@ -184,8 +184,8 @@ void ChromeWebViewPermissionHelperDelegate::RequestGeolocationPermission(
bool user_gesture,
const base::Callback<void(bool)>& callback) {
base::DictionaryValue request_info;
- request_info.SetString(guestview::kUrl, requesting_frame.spec());
- request_info.SetBoolean(guestview::kUserGesture, user_gesture);
+ request_info.SetString(guest_view::kUrl, requesting_frame.spec());
+ request_info.SetBoolean(guest_view::kUserGesture, user_gesture);
// It is safe to hold an unretained pointer to
// ChromeWebViewPermissionHelperDelegate because this callback is called from
@@ -268,7 +268,7 @@ void ChromeWebViewPermissionHelperDelegate::RequestFileSystemPermission(
bool allowed_by_default,
const base::Callback<void(bool)>& callback) {
base::DictionaryValue request_info;
- request_info.SetString(guestview::kUrl, url.spec());
+ request_info.SetString(guest_view::kUrl, url.spec());
web_view_permission_helper()->RequestPermission(
WEB_VIEW_PERMISSION_TYPE_FILESYSTEM,
request_info,

Powered by Google App Engine
This is Rietveld 408576698