Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: extensions/browser/guest_view/guest_view_manager_unittest.cc

Issue 1102173002: Move GuestView layer in browser to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed John's comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_manager_unittest.cc
diff --git a/extensions/browser/guest_view/guest_view_manager_unittest.cc b/extensions/browser/guest_view/guest_view_manager_unittest.cc
deleted file mode 100644
index 2a380e4e3b9e8ecef591bd417757b6529f3a4126..0000000000000000000000000000000000000000
--- a/extensions/browser/guest_view/guest_view_manager_unittest.cc
+++ /dev/null
@@ -1,92 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "extensions/browser/guest_view/guest_view_manager.h"
-
-#include "content/public/browser/notification_service.h"
-#include "content/public/test/test_browser_context.h"
-#include "content/public/test/test_browser_thread_bundle.h"
-#include "content/public/test/web_contents_tester.h"
-#include "extensions/browser/extensions_test.h"
-#include "extensions/browser/guest_view/extensions_guest_view_manager_delegate.h"
-#include "extensions/browser/guest_view/guest_view_manager.h"
-#include "extensions/browser/guest_view/guest_view_manager_delegate.h"
-#include "extensions/browser/guest_view/test_guest_view_manager.h"
-
-using content::WebContents;
-using content::WebContentsTester;
-using guestview::GuestViewManagerDelegate;
-
-namespace extensions {
-
-namespace {
-
-class GuestViewManagerTest : public extensions::ExtensionsTest {
- public:
- GuestViewManagerTest() :
- notification_service_(content::NotificationService::Create()) {}
- ~GuestViewManagerTest() override {}
-
- scoped_ptr<WebContents> CreateWebContents() {
- return scoped_ptr<WebContents>(
- WebContentsTester::CreateTestWebContents(&browser_context_, NULL));
- }
-
- private:
- scoped_ptr<content::NotificationService> notification_service_;
- content::TestBrowserThreadBundle thread_bundle_;
- content::TestBrowserContext browser_context_;
-
- DISALLOW_COPY_AND_ASSIGN(GuestViewManagerTest);
-};
-
-} // namespace
-
-TEST_F(GuestViewManagerTest, AddRemove) {
- content::TestBrowserContext browser_context;
- scoped_ptr<GuestViewManagerDelegate> delegate(
- new ExtensionsGuestViewManagerDelegate(&browser_context));
- scoped_ptr<TestGuestViewManager> manager(
- new extensions::TestGuestViewManager(&browser_context, delegate.Pass()));
-
- scoped_ptr<WebContents> web_contents1(CreateWebContents());
- scoped_ptr<WebContents> web_contents2(CreateWebContents());
- scoped_ptr<WebContents> web_contents3(CreateWebContents());
-
- EXPECT_EQ(0, manager->last_instance_id_removed());
-
- EXPECT_TRUE(manager->CanUseGuestInstanceID(1));
- EXPECT_TRUE(manager->CanUseGuestInstanceID(2));
- EXPECT_TRUE(manager->CanUseGuestInstanceID(3));
-
- manager->AddGuest(1, web_contents1.get());
- manager->AddGuest(2, web_contents2.get());
- manager->RemoveGuest(2);
-
- // Since we removed 2, it would be an invalid ID.
- EXPECT_TRUE(manager->CanUseGuestInstanceID(1));
- EXPECT_FALSE(manager->CanUseGuestInstanceID(2));
- EXPECT_TRUE(manager->CanUseGuestInstanceID(3));
-
- EXPECT_EQ(0, manager->last_instance_id_removed());
-
- EXPECT_TRUE(manager->CanUseGuestInstanceID(3));
-
- manager->AddGuest(3, web_contents3.get());
- manager->RemoveGuest(1);
- EXPECT_FALSE(manager->CanUseGuestInstanceID(1));
- EXPECT_FALSE(manager->CanUseGuestInstanceID(2));
-
- EXPECT_EQ(2, manager->last_instance_id_removed());
- manager->RemoveGuest(3);
- EXPECT_EQ(3, manager->last_instance_id_removed());
-
- EXPECT_FALSE(manager->CanUseGuestInstanceID(1));
- EXPECT_FALSE(manager->CanUseGuestInstanceID(2));
- EXPECT_FALSE(manager->CanUseGuestInstanceID(3));
-
- EXPECT_EQ(0, manager->GetNumRemovedInstanceIDs());
-}
-
-} // namespace extensions
« no previous file with comments | « extensions/browser/guest_view/guest_view_manager_factory.h ('k') | extensions/browser/guest_view/guest_view_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698