Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Issue 1102173002: Move GuestView layer in browser to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed John's comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/stringprintf.h" 5 #include "base/strings/stringprintf.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "chrome/app/chrome_command_ids.h" 7 #include "chrome/app/chrome_command_ids.h"
8 #include "chrome/browser/apps/app_browsertest_util.h" 8 #include "chrome/browser/apps/app_browsertest_util.h"
9 #include "chrome/browser/chrome_content_browser_client.h" 9 #include "chrome/browser/chrome_content_browser_client.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
11 #include "chrome/browser/renderer_context_menu/render_view_context_menu_browsert est_util.h" 11 #include "chrome/browser/renderer_context_menu/render_view_context_menu_browsert est_util.h"
12 #include "chrome/browser/renderer_context_menu/render_view_context_menu_test_uti l.h" 12 #include "chrome/browser/renderer_context_menu/render_view_context_menu_test_uti l.h"
13 #include "chrome/test/base/interactive_test_utils.h" 13 #include "chrome/test/base/interactive_test_utils.h"
14 #include "chrome/test/base/test_launcher_utils.h" 14 #include "chrome/test/base/test_launcher_utils.h"
15 #include "chrome/test/base/ui_test_utils.h" 15 #include "chrome/test/base/ui_test_utils.h"
16 #include "components/guest_view/browser/guest_view_base.h"
17 #include "components/guest_view/browser/guest_view_manager.h"
18 #include "components/guest_view/browser/guest_view_manager_factory.h"
19 #include "components/guest_view/browser/test_guest_view_manager.h"
16 #include "content/public/browser/notification_service.h" 20 #include "content/public/browser/notification_service.h"
17 #include "content/public/browser/render_process_host.h" 21 #include "content/public/browser/render_process_host.h"
18 #include "content/public/browser/render_view_host.h" 22 #include "content/public/browser/render_view_host.h"
19 #include "content/public/browser/render_widget_host_iterator.h" 23 #include "content/public/browser/render_widget_host_iterator.h"
20 #include "content/public/browser/render_widget_host_view.h" 24 #include "content/public/browser/render_widget_host_view.h"
21 #include "content/public/browser/web_contents.h" 25 #include "content/public/browser/web_contents.h"
22 #include "content/public/common/content_switches.h" 26 #include "content/public/common/content_switches.h"
23 #include "content/public/test/browser_test_utils.h" 27 #include "content/public/test/browser_test_utils.h"
24 #include "extensions/browser/app_window/app_window.h" 28 #include "extensions/browser/app_window/app_window.h"
25 #include "extensions/browser/app_window/app_window_registry.h" 29 #include "extensions/browser/app_window/app_window_registry.h"
26 #include "extensions/browser/guest_view/extensions_guest_view_manager_delegate.h " 30 #include "extensions/browser/guest_view/extensions_guest_view_manager_delegate.h "
27 #include "extensions/browser/guest_view/guest_view_base.h"
28 #include "extensions/browser/guest_view/guest_view_manager.h"
29 #include "extensions/browser/guest_view/guest_view_manager_factory.h"
30 #include "extensions/browser/guest_view/test_guest_view_manager.h"
31 #include "extensions/test/extension_test_message_listener.h" 31 #include "extensions/test/extension_test_message_listener.h"
32 #include "net/test/embedded_test_server/embedded_test_server.h" 32 #include "net/test/embedded_test_server/embedded_test_server.h"
33 #include "ui/base/ime/composition_text.h" 33 #include "ui/base/ime/composition_text.h"
34 #include "ui/base/ime/text_input_client.h" 34 #include "ui/base/ime/text_input_client.h"
35 #include "ui/base/test/ui_controls.h" 35 #include "ui/base/test/ui_controls.h"
36 #include "ui/events/keycodes/keyboard_codes.h" 36 #include "ui/events/keycodes/keyboard_codes.h"
37 37
38 using extensions::AppWindow; 38 using extensions::AppWindow;
39 using extensions::ExtensionsGuestViewManagerDelegate; 39 using extensions::ExtensionsGuestViewManagerDelegate;
40 using extensions::GuestViewManager; 40 using guest_view::GuestViewBase;
41 using extensions::TestGuestViewManager; 41 using guest_view::GuestViewManager;
42 using guest_view::TestGuestViewManager;
43 using guest_view::TestGuestViewManagerFactory;
42 44
43 class WebViewInteractiveTest 45 class WebViewInteractiveTest
44 : public extensions::PlatformAppBrowserTest { 46 : public extensions::PlatformAppBrowserTest {
45 public: 47 public:
46 WebViewInteractiveTest() 48 WebViewInteractiveTest()
47 : guest_web_contents_(NULL), 49 : guest_web_contents_(NULL),
48 embedder_web_contents_(NULL), 50 embedder_web_contents_(NULL),
49 corner_(gfx::Point()), 51 corner_(gfx::Point()),
50 mouse_click_result_(false), 52 mouse_click_result_(false),
51 first_click_(true) { 53 first_click_(true) {
52 extensions::GuestViewManager::set_factory_for_testing(&factory_); 54 GuestViewManager::set_factory_for_testing(&factory_);
53 } 55 }
54 56
55 TestGuestViewManager* GetGuestViewManager() { 57 TestGuestViewManager* GetGuestViewManager() {
56 TestGuestViewManager* manager = static_cast<TestGuestViewManager*>( 58 TestGuestViewManager* manager = static_cast<TestGuestViewManager*>(
57 TestGuestViewManager::FromBrowserContext(browser()->profile())); 59 TestGuestViewManager::FromBrowserContext(browser()->profile()));
58 // TestGuestViewManager::WaitForSingleGuestCreated may and will get called 60 // TestGuestViewManager::WaitForSingleGuestCreated may and will get called
59 // before a guest is created. 61 // before a guest is created.
60 if (!manager) { 62 if (!manager) {
61 manager = static_cast<TestGuestViewManager*>( 63 manager = static_cast<TestGuestViewManager*>(
62 GuestViewManager::CreateWithDelegate( 64 GuestViewManager::CreateWithDelegate(
63 browser()->profile(), 65 browser()->profile(),
64 scoped_ptr<guestview::GuestViewManagerDelegate>( 66 scoped_ptr<guest_view::GuestViewManagerDelegate>(
65 new ExtensionsGuestViewManagerDelegate( 67 new ExtensionsGuestViewManagerDelegate(
66 browser()->profile())))); 68 browser()->profile()))));
67 } 69 }
68 return manager; 70 return manager;
69 } 71 }
70 72
71 void MoveMouseInsideWindowWithListener(gfx::Point point, 73 void MoveMouseInsideWindowWithListener(gfx::Point point,
72 const std::string& message) { 74 const std::string& message) {
73 ExtensionTestMessageListener move_listener(message, false); 75 ExtensionTestMessageListener move_listener(message, false);
74 ASSERT_TRUE(ui_test_utils::SendMouseMoveSync( 76 ASSERT_TRUE(ui_test_utils::SendMouseMoveSync(
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 LoadAndLaunchPlatformApp(app_name.c_str(), "connected"); 239 LoadAndLaunchPlatformApp(app_name.c_str(), "connected");
238 240
239 guest_observer.Wait(); 241 guest_observer.Wait();
240 content::Source<content::NavigationController> source = 242 content::Source<content::NavigationController> source =
241 guest_observer.source(); 243 guest_observer.source();
242 EXPECT_TRUE(source->GetWebContents()->GetRenderProcessHost()-> 244 EXPECT_TRUE(source->GetWebContents()->GetRenderProcessHost()->
243 IsIsolatedGuest()); 245 IsIsolatedGuest());
244 246
245 guest_web_contents_ = source->GetWebContents(); 247 guest_web_contents_ = source->GetWebContents();
246 embedder_web_contents_ = 248 embedder_web_contents_ =
247 extensions::GuestViewBase::FromWebContents(guest_web_contents_)-> 249 GuestViewBase::FromWebContents(guest_web_contents_)->
248 embedder_web_contents(); 250 embedder_web_contents();
249 251
250 gfx::Rect offset = embedder_web_contents_->GetContainerBounds(); 252 gfx::Rect offset = embedder_web_contents_->GetContainerBounds();
251 corner_ = gfx::Point(offset.x(), offset.y()); 253 corner_ = gfx::Point(offset.x(), offset.y());
252 254
253 const testing::TestInfo* const test_info = 255 const testing::TestInfo* const test_info =
254 testing::UnitTest::GetInstance()->current_test_info(); 256 testing::UnitTest::GetInstance()->current_test_info();
255 const char* prefix = "DragDropWithinWebView"; 257 const char* prefix = "DragDropWithinWebView";
256 if (!strncmp(test_info->name(), prefix, strlen(prefix))) { 258 if (!strncmp(test_info->name(), prefix, strlen(prefix))) {
257 // In the drag drop test we add 20px padding to the page body because on 259 // In the drag drop test we add 20px padding to the page body because on
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
473 "FULLSCREEN_STEP_PASSED", false); 475 "FULLSCREEN_STEP_PASSED", false);
474 passed_listener.set_failure_message("TEST_FAILED"); 476 passed_listener.set_failure_message("TEST_FAILED");
475 content::SimulateMouseClickAt(guest_web_contents(), 477 content::SimulateMouseClickAt(guest_web_contents(),
476 0, 478 0,
477 blink::WebMouseEvent::ButtonLeft, 479 blink::WebMouseEvent::ButtonLeft,
478 gfx::Point(20, 20)); 480 gfx::Point(20, 20));
479 ASSERT_TRUE(passed_listener.WaitUntilSatisfied()); 481 ASSERT_TRUE(passed_listener.WaitUntilSatisfied());
480 } 482 }
481 483
482 protected: 484 protected:
483 extensions::TestGuestViewManagerFactory factory_; 485 TestGuestViewManagerFactory factory_;
484 content::WebContents* guest_web_contents_; 486 content::WebContents* guest_web_contents_;
485 content::WebContents* embedder_web_contents_; 487 content::WebContents* embedder_web_contents_;
486 gfx::Point corner_; 488 gfx::Point corner_;
487 bool mouse_click_result_; 489 bool mouse_click_result_;
488 bool first_click_; 490 bool first_click_;
489 // Only used in drag/drop test. 491 // Only used in drag/drop test.
490 base::Closure quit_closure_; 492 base::Closure quit_closure_;
491 std::string last_drop_data_; 493 std::string last_drop_data_;
492 }; 494 };
493 495
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
1161 1163
1162 // Now verify that the selection text propagates properly to RWHV. 1164 // Now verify that the selection text propagates properly to RWHV.
1163 content::RenderWidgetHostView* guest_rwhv = 1165 content::RenderWidgetHostView* guest_rwhv =
1164 guest_web_contents()->GetRenderWidgetHostView(); 1166 guest_web_contents()->GetRenderWidgetHostView();
1165 ASSERT_TRUE(guest_rwhv); 1167 ASSERT_TRUE(guest_rwhv);
1166 std::string selected_text = base::UTF16ToUTF8(guest_rwhv->GetSelectedText()); 1168 std::string selected_text = base::UTF16ToUTF8(guest_rwhv->GetSelectedText());
1167 ASSERT_TRUE(selected_text.size() >= 10u); 1169 ASSERT_TRUE(selected_text.size() >= 10u);
1168 ASSERT_EQ("AAAAAAAAAA", selected_text.substr(0, 10)); 1170 ASSERT_EQ("AAAAAAAAAA", selected_text.substr(0, 10));
1169 } 1171 }
1170 #endif 1172 #endif
OLDNEW
« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698