Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1102103002: Move the unit tests files side-by-side with the corresponding .cc files. (Closed)

Created:
5 years, 8 months ago by Sorin Jianu
Modified:
5 years, 8 months ago
CC:
chromium-reviews, pam+watch_chromium.org, cpu_(ooo_6.6-7.5)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the unit tests files side-by-side with the corresponding .cc files. This is a mechanical change. The idea here is that we want to simplify the directory tree of the component updater files and easily see what compilation unit has tests and which one does not. This change includes some whitespace changes due to running git cl format. BUG=479904 Committed: https://crrev.com/b120440b979924e5100ee2ff9b484a39d0584c59 Cr-Commit-Position: refs/heads/master@{#327054}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments from waffles #

Total comments: 1

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -6242 lines) Patch
A + chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/browser/component_updater/cld_component_installer_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/component_updater/component_installers_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
A + chrome/browser/component_updater/component_updater_service_unittest.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/component_updater/component_updater_service_unittest.cc View 24 chunks +81 lines, -107 lines 0 comments Download
A + chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/component_updater/test/chrome_component_updater_configurator_unittest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/component_updater/test/cld_component_installer_unittest.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D chrome/browser/component_updater/test/component_installers_unittest.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/component_updater/test/component_updater_service_unittest.h View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/browser/component_updater/test/component_updater_service_unittest.cc View 1 chunk +0 lines, -1424 lines 0 comments Download
D chrome/browser/component_updater/test/supervised_user_whitelist_installer_unittest.cc View 1 chunk +0 lines, -369 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M components/components_tests.gyp View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M components/update_client.gypi View 1 chunk +6 lines, -6 lines 0 comments Download
M components/update_client/BUILD.gn View 2 chunks +13 lines, -13 lines 0 comments Download
M components/update_client/DEPS View 1 1 chunk +9 lines, -1 line 0 comments Download
A + components/update_client/component_patcher_unittest.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/update_client/component_patcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/update_client/crx_downloader_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/update_client/ping_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/update_client/request_sender_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D components/update_client/test/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D components/update_client/test/component_patcher_unittest.h View 1 chunk +0 lines, -42 lines 0 comments Download
D components/update_client/test/component_patcher_unittest.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D components/update_client/test/crx_downloader_unittest.cc View 1 chunk +0 lines, -382 lines 0 comments Download
D components/update_client/test/ping_manager_unittest.cc View 1 chunk +0 lines, -178 lines 0 comments Download
D components/update_client/test/request_sender_unittest.cc View 1 chunk +0 lines, -206 lines 0 comments Download
D components/update_client/test/test_configurator.h View 1 chunk +0 lines, -111 lines 0 comments Download
D components/update_client/test/test_configurator.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D components/update_client/test/test_installer.h View 1 chunk +0 lines, -88 lines 0 comments Download
D components/update_client/test/test_installer.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D components/update_client/test/update_checker_unittest.cc View 1 chunk +0 lines, -237 lines 0 comments Download
D components/update_client/test/update_client_unittest.cc View 1 chunk +0 lines, -1422 lines 0 comments Download
D components/update_client/test/update_response_unittest.cc View 1 chunk +0 lines, -302 lines 0 comments Download
D components/update_client/test/url_request_post_interceptor.h View 1 chunk +0 lines, -165 lines 0 comments Download
D components/update_client/test/url_request_post_interceptor.cc View 1 chunk +0 lines, -301 lines 0 comments Download
A + components/update_client/test_configurator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/update_client/test_configurator.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/update_client/test_installer.h View 3 chunks +5 lines, -9 lines 0 comments Download
A + components/update_client/test_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/update_client/update_checker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/update_client/update_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/update_client/update_response_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/update_client/url_request_post_interceptor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/update_client/url_request_post_interceptor.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Sorin Jianu
This change looks large but is is just moving a couple of component updater-related files ...
5 years, 8 months ago (2015-04-24 20:23:30 UTC) #3
waffles
lgtm https://codereview.chromium.org/1102103002/diff/1/components/update_client/DEPS File components/update_client/DEPS (right): https://codereview.chromium.org/1102103002/diff/1/components/update_client/DEPS#newcode15 components/update_client/DEPS:15: # message loops directlyy. typo: directlyy
5 years, 8 months ago (2015-04-24 21:15:55 UTC) #4
blundell
//components lgtm Please do the mentioned refactoring soon though :)
5 years, 8 months ago (2015-04-27 09:58:45 UTC) #5
jam
https://codereview.chromium.org/1102103002/diff/20001/components/update_client/DEPS File components/update_client/DEPS (right): https://codereview.chromium.org/1102103002/diff/20001/components/update_client/DEPS#newcode14 components/update_client/DEPS:14: # TODO(sorin): refactor to eliminate the dependency on content ...
5 years, 8 months ago (2015-04-27 14:40:46 UTC) #6
Sorin Jianu
Thank you jam@. I prefer moving the files to to be a mechanical change. I ...
5 years, 8 months ago (2015-04-27 14:46:38 UTC) #7
jam
On 2015/04/27 14:46:38, Sorin Jianu wrote: > Thank you jam@. I prefer moving the files ...
5 years, 8 months ago (2015-04-27 15:46:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102103002/40001
5 years, 8 months ago (2015-04-27 16:03:32 UTC) #11
Sorin Jianu
James, I need an owner approval for chrome/chrome_tests_unit.gypi ty!
5 years, 8 months ago (2015-04-27 16:31:36 UTC) #13
James Hawkins
lgtm
5 years, 8 months ago (2015-04-27 16:32:03 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-27 16:34:25 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 16:35:16 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b120440b979924e5100ee2ff9b484a39d0584c59
Cr-Commit-Position: refs/heads/master@{#327054}

Powered by Google App Engine
This is Rietveld 408576698