Implementing a BLE connection finder.

Implementing a BLE connection finder.

This is a fixed version of https://codereview.chromium.org/1094273003/,
that was reverted due to a global const std:string.

BUG=479673
Committed: https://crrev.com/8d080c8e59b18ef4dc46f3a03cc6a15f634868af
Cr-Commit-Position: refs/heads/master@{#327022}

[sacomoto, 2015-04-24 19:04:43]

sacomoto@chromium.org changed reviewers:
+ msarda@chromium.org, tengs@chromium.org

[sacomoto, 2015-04-24 19:05:05]

PTAL.

[Tim Song, 2015-04-24 19:26:21]

lgtm

https://codereview.chromium.org/1102093002/diff/1/components/proximity_auth/b...
File components/proximity_auth/ble/proximity_auth_ble_system.cc (right):

https://codereview.chromium.org/1102093002/diff/1/components/proximity_auth/b...
components/proximity_auth/ble/proximity_auth_ble_system.cc:33:
connection_finder_.reset();
nit: you don't need explicitly call reset in the destructor.

[msarda, 2015-04-27 08:01:32]

On 2015/04/24 19:26:21, Tim Song wrote:
> lgtm
> 
>
https://codereview.chromium.org/1102093002/diff/1/components/proximity_auth/b...
> File components/proximity_auth/ble/proximity_auth_ble_system.cc (right):
> 
>
https://codereview.chromium.org/1102093002/diff/1/components/proximity_auth/b...
> components/proximity_auth/ble/proximity_auth_ble_system.cc:33:
> connection_finder_.reset();
> nit: you don't need explicitly call reset in the destructor.

I need this CL to land and Gustavo is OOO today. I'll land it as is and fix the
nit in my own CL afterwards.

[msarda, 2015-04-27 08:11:07]

LGTM with some nits.

https://codereview.chromium.org/1102093002/diff/1/components/proximity_auth/b...
File components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h
(right):

https://codereview.chromium.org/1102093002/diff/1/components/proximity_auth/b...
components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h:32: //
Finds a connection the remote device, only the first one is functional.
s/connection the/connection to the

https://codereview.chromium.org/1102093002/diff/1/components/proximity_auth/b...
File components/proximity_auth/ble/proximity_auth_ble_system.cc (right):

https://codereview.chromium.org/1102093002/diff/1/components/proximity_auth/b...
components/proximity_auth/ble/proximity_auth_ble_system.cc:13: #include
"components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h"
Include order should be fixed.

https://codereview.chromium.org/1102093002/diff/1/components/proximity_auth/b...
components/proximity_auth/ble/proximity_auth_ble_system.cc:17: const char
kSmartLockServiceUUID[] = "b3b7e28e-a000-3e17-bd86-6e97b9e28c11";
This should go in an anonymous namespace.

https://codereview.chromium.org/1102093002/diff/1/components/proximity_auth/b...
components/proximity_auth/ble/proximity_auth_ble_system.cc:19: void
ConnectionCallback(
This should go in an anonymous namespace.

https://codereview.chromium.org/1102093002/diff/1/components/proximity_auth/b...
File components/proximity_auth/ble/proximity_auth_ble_system.h (right):

https://codereview.chromium.org/1102093002/diff/1/components/proximity_auth/b...
components/proximity_auth/ble/proximity_auth_ble_system.h:11: #include
"components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h"
Nit: This include seems broken (why blank line before). More that that, we do
not need it in the header - we should just forward declare the class
BluetoothLowEnergyConnectionFinder.

[msarda, 2015-04-27 08:11:27]

I need this CL to land and Gustavo is OOO today. I'll land it as is and fix the
nits in my own CL afterwards.

[msarda, 2015-04-27 08:11:32]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2015-04-27 08:11:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1102093002/1

[commit-bot: I haz the power, 2015-04-27 10:04:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-27 10:05:27]

Patchset 1 (id:??) landed as
https://crrev.com/8d080c8e59b18ef4dc46f3a03cc6a15f634868af
Cr-Commit-Position: refs/heads/master@{#327022}

[msarda, 2015-04-27 16:15:36]

I'm fixing the remaining nits in CL https://codereview.chromium.org/1102473003/