Issue 1102043002: Preserve embedded DEPS files during mojo roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1102043002: Preserve embedded DEPS files during mojo roll (Closed)

Created:
5 years, 8 months ago by Ken Rockot(use gerrit already)

Modified:
5 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Preserve embedded DEPS files during mojo roll These are no longer part of the mojo repo, but we want to persist them when rolling to chromium. This also brings over the small utils module that the script depends on, with some minor adjustments. Rather than taking the chromium path as an arg and inferring the mojo path, we now do the reverse. BUG=None R=jam@chromium.org Committed: https://crrev.com/aea10852fd84b7b22473aeef85f8adeac6771e56 Cr-Commit-Position: refs/heads/master@{#326809}

Patch Set 1 #

Patch Set 2 : Add utils module; update script to take mojo path instead of chromium path #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -6 lines)			Patch
	M	mojo/tools/rev_sdk.py	View	1	3 chunks	+19 lines, -6 lines	0 comments	Download
	A	mojo/tools/utils.py	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102043002/20001

5 years, 8 months ago (2015-04-24 15:38:00 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-24 16:01:31 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/aea10852fd84b7b22473aeef85f8adeac6771e56
Cr-Commit-Position: refs/heads/master@{#326809}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages