Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: ui/accessibility/extensions/colorenhancer/src/popup.html

Issue 1102033005: Fix i18n for the color enhancer extension (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix setup button and css style Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/accessibility/extensions/colorenhancer/src/popup.html
diff --git a/ui/accessibility/extensions/colorenhancer/src/popup.html b/ui/accessibility/extensions/colorenhancer/src/popup.html
index ff5e9906c7cc0c1912d7bc4b6a74c83f6395c972..c29d9b8ca46e6d352452683eaca51e639d1dcc53 100644
--- a/ui/accessibility/extensions/colorenhancer/src/popup.html
+++ b/ui/accessibility/extensions/colorenhancer/src/popup.html
@@ -16,14 +16,13 @@
<script type="text/javascript" src="popup.js"></script>
</head>
<body>
- <h2><span i18n-content="IDS_COLOR_ENHANCER_APPNAME">Color Enhancer<span></h2>
+ <h2><span i18n-content="color_enhancer_appname"><span></h2>
<table>
<tr>
- <th><span i18n-content="IDS_COLOR_ENHANCER_ENABLE">Enable?</span></th>
+ <th><span i18n-content="color_enhancer_enable"></span></th>
<th>
- <span i18n-content="IDS_COLOR_ENHANCER_ADJUSTMENT_FACTOR">
- Color adjustment
+ <span i18n-content="color_enhancer_adjustment_factor">
</span>
</th>
</tr>
@@ -34,21 +33,19 @@
defaultValue="0.5">
</td>
<td>
- <!-- TOOD(kevers): i18n -->
- <input id="setup" type="button" value="Setup">
+ <button id="setup" i18n-content="color_enhancer_setup"></button>
</td>
</tr>
</table>
</div>
- <div id="setup-panel" class = "collapsed">
- <h3><span i18n-content="IDS_COLOR_ENHANCER_ADVANCED">Setup:</span></h3>
+ <div id="setup-panel" class="collapsed">
+ <h3><span i18n-content="color_enhancer_setup"></span></h3>
<section id="step-1">
<div>
- <span i18n-content="IDS_COLOR_ENHANCER_TYPE_CHOICE">
- Step 1: Select the row with the faintest stars:
+ <span i18n-content="color_enhancer_type_choice">
</span>
- </div>
+ </div>
<div class="template swatch">
<span>&#x22c6</span>
</div>
@@ -59,18 +56,15 @@
</section>
<section id="step-2">
<div>
- <span i18n-content="IDS_COLOR_ENHANCER_SEVERITY">
- Step 2: Adjust the slider until all of the stars are visible in the
- selected row
+ <span i18n-content="color_enhancer_severity">
</span>
<input id="severity" type="range" min=0 max=1.0 step=0.1 value="0">
</div>
</section>
<div id="setup-button-strip" class="row">
- <!-- TODO(kevers): i18n -->
- <input id="reset" type="button" value="Reset">
- <input id="ok" type="button" value="OK">
- <input id="cancel" type="button" value="Cancel">
+ <button id="reset" i18n-content="color_enhancer_reset"></button>
+ <button id="ok" i18n-content="color_enhancer_ok"></button>
+ <button id="cancel" i18n-content="color_enhancer_cancel"></button>
</div>
</div>
</body>

Powered by Google App Engine
This is Rietveld 408576698