Fix i18n for the color enhancer extension

ui/accessibility/extensions/colorenhancer/src/popup.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var site;
 
 /**
  * Toggle between filters 0 and 1 in order to force a repaint.
  * TODO(kevers): Consolidate with filter in CVD.
  * @type {!number}
@@ skipping 89 matching lines @@
  * Creates a radio button for selecting the given type of CVD and a series of
  * color swatches for testing color vision.
  * @param {string} cvdType Type of CVD, either "PROTANOMALY" or "DEUTERANOMALY"
  *     or "TRITANOMALY".
  *  @return {!Element} Row of color swatches with a leading radio button.
  */
 function createTestRow(type) {
   var toCssColor = function(rgb) {
     return 'rgb(' + rgb.join(',') + ')';
   };
-  var row = document.createElement('div');
+  var row = document.createElement('label');
   row.classList.add('row');
 
   var button = document.createElement('input');
   button.id = 'select-' + type;
   button.name = 'cvdType';
   button.setAttribute('type', 'radio');
   button.value = type;
   button.checked = false;
   row.appendChild(button);
   button.addEventListener('change', function() {
     onTypeChange(this.value);
   });
+  button.setAttribute('aria-label', type);
 
   SWATCH_COLORS.forEach(function(data) {
     var swatch = document.querySelector('.swatch.template').cloneNode(true);
     swatch.style.background = toCssColor(data.BACKGROUND);
     swatch.style.color = toCssColor(data[type]);
     swatch.classList.remove('template');
     row.appendChild(swatch);
   });
   return row;
 }
@@ skipping 180 matching lines @@
   debugPrint('onReset');
   resetSiteDeltas();
   update();
 }
 
 /**
  * Attach event handlers to controls and update the filter config values for the
  * currently visible tab.
  */
 function initialize() {
+  var i18nElements = document.querySelectorAll('*[i18n-content]');
+  for (var i = 0; i < i18nElements.length; i++) {
+    var elem = i18nElements[i];
+    var msg = elem.getAttribute('i18n-content');
+    elem.innerHTML = chrome.i18n.getMessage(msg);

[kevers, 2015/04/27 13:57:36]

Thanks for fixing i18n!

Would it be safer to use textContent instead of innerHTML?

[dmazzoni, 2015/04/27 19:47:47]

Done.

+  }
+
   $('setup').onclick = function() {
+    console.log('Click setup');

[kevers, 2015/04/27 13:57:36]

Please remove console.log here and below or switch to debugPrint, which will
suppress the output outside of dev mode.

[dmazzoni, 2015/04/27 19:47:47]

Done.

     $('setup-panel').classList.remove('collapsed');
     // Store current settings in the event of a canceled setup.
     restoreSettings = {
       type: getDefaultType(),
       severity: getDefaultSeverity()
     };
     // Initalize controls based on current settings.
     setCvdTypeSelection(restoreSettings.type);
     $('severity').value = restoreSettings.severity;
     updateControls();
   };
 
+  console.log('init 5');
+
   $('delta').addEventListener('input', function() {
     onDeltaChange(parseFloat(this.value));
   });
   $('severity').addEventListener('input', function() {
     onSeverityChange(parseFloat(this.value));
   });
   $('enable').addEventListener('change', function() {
     onEnableChange(this.checked);
   });
 
@@ skipping 45 matching lines @@
         return;
       }
     }
     site = 'unknown site';
     update();
   });
 }
 
 // TODO(wnwen): Use Promise instead, more reliable.
 window.addEventListener('load', initialize, false);