Fix i18n for the color enhancer extension

Fix i18n for the color enhancer extension

Also makes the radio buttons accessible and makes it possible to click anywhere on the color tiles to select the corresponding radio button.

BUG=none

Committed: https://crrev.com/1a50a521f63d91545d2cf33ee6c7c6b28da4ab8d
Cr-Commit-Position: refs/heads/master@{#327106}

[dmazzoni, 2015-04-24 23:10:27]

dmazzoni@chromium.org changed reviewers:
+ kevers@chromium.org, mustaq@chromium.org

[kevers, 2015-04-27 13:57:36]

LGTM with nits.

https://codereview.chromium.org/1102033005/diff/20001/ui/accessibility/extens...
File ui/accessibility/extensions/colorenhancer/src/popup.js (right):

https://codereview.chromium.org/1102033005/diff/20001/ui/accessibility/extens...
ui/accessibility/extensions/colorenhancer/src/popup.js:328: elem.innerHTML =
chrome.i18n.getMessage(msg);
Thanks for fixing i18n!

Would it be safer to use textContent instead of innerHTML?

https://codereview.chromium.org/1102033005/diff/20001/ui/accessibility/extens...
ui/accessibility/extensions/colorenhancer/src/popup.js:332: console.log('Click
setup');
Please remove console.log here and below or switch to debugPrint, which will
suppress the output outside of dev mode.

[mustaq, 2015-04-27 14:17:11]

https://codereview.chromium.org/1102033005/diff/20001/ui/accessibility/extens...
File ui/accessibility/extensions/strings/accessibility_extensions_strings.grd
(right):

https://codereview.chromium.org/1102033005/diff/20001/ui/accessibility/extens...
ui/accessibility/extensions/strings/accessibility_extensions_strings.grd:307:
<message desc="Button for the color enhancer popup that opens the Setup part of
the popup." name="IDS_COLOR_ENHANCER_SETUP">
This id seems duplicate: Duplicate IDS_COLOR_ENHANCER_SETUP.

[dmazzoni, 2015-04-27 19:47:47]

https://codereview.chromium.org/1102033005/diff/20001/ui/accessibility/extens...
File ui/accessibility/extensions/colorenhancer/src/popup.js (right):

https://codereview.chromium.org/1102033005/diff/20001/ui/accessibility/extens...
ui/accessibility/extensions/colorenhancer/src/popup.js:328: elem.innerHTML =
chrome.i18n.getMessage(msg);
On 2015/04/27 13:57:36, kevers wrote:
> Thanks for fixing i18n!
> 
> Would it be safer to use textContent instead of innerHTML?
> 

Done.

https://codereview.chromium.org/1102033005/diff/20001/ui/accessibility/extens...
ui/accessibility/extensions/colorenhancer/src/popup.js:332: console.log('Click
setup');
On 2015/04/27 13:57:36, kevers wrote:
> Please remove console.log here and below or switch to debugPrint, which will
> suppress the output outside of dev mode.

Done.

https://codereview.chromium.org/1102033005/diff/20001/ui/accessibility/extens...
File ui/accessibility/extensions/strings/accessibility_extensions_strings.grd
(right):

https://codereview.chromium.org/1102033005/diff/20001/ui/accessibility/extens...
ui/accessibility/extensions/strings/accessibility_extensions_strings.grd:307:
<message desc="Button for the color enhancer popup that opens the Setup part of
the popup." name="IDS_COLOR_ENHANCER_SETUP">
On 2015/04/27 14:17:10, mustaq wrote:
> This id seems duplicate: Duplicate IDS_COLOR_ENHANCER_SETUP.

Good catch. Split into SETUP_BUTTON and SETUP_HEADING

[dmazzoni, 2015-04-27 19:47:55]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-04-27 19:47:56]

The patchset sent to the CQ was uploaded after l-g-t-m from kevers@chromium.org
Link to the patchset: https://codereview.chromium.org/1102033005/#ps40001
(title: "Address feedback")

[commit-bot: I haz the power, 2015-04-27 19:48:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1102033005/40001

[commit-bot: I haz the power, 2015-04-27 19:55:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-27 19:56:16]

Patchset 3 (id:??) landed as
https://crrev.com/1a50a521f63d91545d2cf33ee6c7c6b28da4ab8d
Cr-Commit-Position: refs/heads/master@{#327106}