Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: src/optimizing-compiler-thread.h

Issue 110203002: Refactor the compiling pipeline. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-inl.h ('k') | src/optimizing-compiler-thread.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 22 matching lines...) Expand all
33 #include "list.h" 33 #include "list.h"
34 #include "platform.h" 34 #include "platform.h"
35 #include "platform/mutex.h" 35 #include "platform/mutex.h"
36 #include "platform/time.h" 36 #include "platform/time.h"
37 #include "unbound-queue-inl.h" 37 #include "unbound-queue-inl.h"
38 38
39 namespace v8 { 39 namespace v8 {
40 namespace internal { 40 namespace internal {
41 41
42 class HOptimizedGraphBuilder; 42 class HOptimizedGraphBuilder;
43 class RecompileJob; 43 class OptimizedCompileJob;
44 class SharedFunctionInfo; 44 class SharedFunctionInfo;
45 45
46 class OptimizingCompilerThread : public Thread { 46 class OptimizingCompilerThread : public Thread {
47 public: 47 public:
48 explicit OptimizingCompilerThread(Isolate *isolate) : 48 explicit OptimizingCompilerThread(Isolate *isolate) :
49 Thread("OptimizingCompilerThread"), 49 Thread("OptimizingCompilerThread"),
50 #ifdef DEBUG 50 #ifdef DEBUG
51 thread_id_(0), 51 thread_id_(0),
52 #endif 52 #endif
53 isolate_(isolate), 53 isolate_(isolate),
54 stop_semaphore_(0), 54 stop_semaphore_(0),
55 input_queue_semaphore_(0), 55 input_queue_semaphore_(0),
56 input_queue_capacity_(FLAG_concurrent_recompilation_queue_length), 56 input_queue_capacity_(FLAG_concurrent_recompilation_queue_length),
57 input_queue_length_(0), 57 input_queue_length_(0),
58 input_queue_shift_(0), 58 input_queue_shift_(0),
59 osr_buffer_capacity_(FLAG_concurrent_recompilation_queue_length + 4), 59 osr_buffer_capacity_(FLAG_concurrent_recompilation_queue_length + 4),
60 osr_buffer_cursor_(0), 60 osr_buffer_cursor_(0),
61 osr_hits_(0), 61 osr_hits_(0),
62 osr_attempts_(0), 62 osr_attempts_(0),
63 blocked_jobs_(0) { 63 blocked_jobs_(0) {
64 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(CONTINUE)); 64 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(CONTINUE));
65 input_queue_ = NewArray<RecompileJob*>(input_queue_capacity_); 65 input_queue_ = NewArray<OptimizedCompileJob*>(input_queue_capacity_);
66 if (FLAG_concurrent_osr) { 66 if (FLAG_concurrent_osr) {
67 // Allocate and mark OSR buffer slots as empty. 67 // Allocate and mark OSR buffer slots as empty.
68 osr_buffer_ = NewArray<RecompileJob*>(osr_buffer_capacity_); 68 osr_buffer_ = NewArray<OptimizedCompileJob*>(osr_buffer_capacity_);
69 for (int i = 0; i < osr_buffer_capacity_; i++) osr_buffer_[i] = NULL; 69 for (int i = 0; i < osr_buffer_capacity_; i++) osr_buffer_[i] = NULL;
70 } 70 }
71 } 71 }
72 72
73 ~OptimizingCompilerThread(); 73 ~OptimizingCompilerThread();
74 74
75 void Run(); 75 void Run();
76 void Stop(); 76 void Stop();
77 void Flush(); 77 void Flush();
78 void QueueForOptimization(RecompileJob* optimizing_compiler); 78 void QueueForOptimization(OptimizedCompileJob* optimizing_compiler);
79 void Unblock(); 79 void Unblock();
80 void InstallOptimizedFunctions(); 80 void InstallOptimizedFunctions();
81 RecompileJob* FindReadyOSRCandidate(Handle<JSFunction> function, 81 OptimizedCompileJob* FindReadyOSRCandidate(Handle<JSFunction> function,
82 uint32_t osr_pc_offset); 82 BailoutId osr_ast_id);
83 bool IsQueuedForOSR(Handle<JSFunction> function, uint32_t osr_pc_offset); 83 bool IsQueuedForOSR(Handle<JSFunction> function, BailoutId osr_ast_id);
84 84
85 bool IsQueuedForOSR(JSFunction* function); 85 bool IsQueuedForOSR(JSFunction* function);
86 86
87 inline bool IsQueueAvailable() { 87 inline bool IsQueueAvailable() {
88 LockGuard<Mutex> access_input_queue(&input_queue_mutex_); 88 LockGuard<Mutex> access_input_queue(&input_queue_mutex_);
89 return input_queue_length_ < input_queue_capacity_; 89 return input_queue_length_ < input_queue_capacity_;
90 } 90 }
91 91
92 inline void AgeBufferedOsrJobs() { 92 inline void AgeBufferedOsrJobs() {
93 // Advance cursor of the cyclic buffer to next empty slot or stale OSR job. 93 // Advance cursor of the cyclic buffer to next empty slot or stale OSR job.
(...skipping 11 matching lines...) Expand all
105 bool IsOptimizerThread(); 105 bool IsOptimizerThread();
106 #endif 106 #endif
107 107
108 private: 108 private:
109 enum StopFlag { CONTINUE, STOP, FLUSH }; 109 enum StopFlag { CONTINUE, STOP, FLUSH };
110 110
111 void FlushInputQueue(bool restore_function_code); 111 void FlushInputQueue(bool restore_function_code);
112 void FlushOutputQueue(bool restore_function_code); 112 void FlushOutputQueue(bool restore_function_code);
113 void FlushOsrBuffer(bool restore_function_code); 113 void FlushOsrBuffer(bool restore_function_code);
114 void CompileNext(); 114 void CompileNext();
115 RecompileJob* NextInput(); 115 OptimizedCompileJob* NextInput();
116 116
117 // Add a recompilation task for OSR to the cyclic buffer, awaiting OSR entry. 117 // Add a recompilation task for OSR to the cyclic buffer, awaiting OSR entry.
118 // Tasks evicted from the cyclic buffer are discarded. 118 // Tasks evicted from the cyclic buffer are discarded.
119 void AddToOsrBuffer(RecompileJob* compiler); 119 void AddToOsrBuffer(OptimizedCompileJob* compiler);
120 120
121 inline int InputQueueIndex(int i) { 121 inline int InputQueueIndex(int i) {
122 int result = (i + input_queue_shift_) % input_queue_capacity_; 122 int result = (i + input_queue_shift_) % input_queue_capacity_;
123 ASSERT_LE(0, result); 123 ASSERT_LE(0, result);
124 ASSERT_LT(result, input_queue_capacity_); 124 ASSERT_LT(result, input_queue_capacity_);
125 return result; 125 return result;
126 } 126 }
127 127
128 #ifdef DEBUG 128 #ifdef DEBUG
129 int thread_id_; 129 int thread_id_;
130 Mutex thread_id_mutex_; 130 Mutex thread_id_mutex_;
131 #endif 131 #endif
132 132
133 Isolate* isolate_; 133 Isolate* isolate_;
134 Semaphore stop_semaphore_; 134 Semaphore stop_semaphore_;
135 Semaphore input_queue_semaphore_; 135 Semaphore input_queue_semaphore_;
136 136
137 // Circular queue of incoming recompilation tasks (including OSR). 137 // Circular queue of incoming recompilation tasks (including OSR).
138 RecompileJob** input_queue_; 138 OptimizedCompileJob** input_queue_;
139 int input_queue_capacity_; 139 int input_queue_capacity_;
140 int input_queue_length_; 140 int input_queue_length_;
141 int input_queue_shift_; 141 int input_queue_shift_;
142 Mutex input_queue_mutex_; 142 Mutex input_queue_mutex_;
143 143
144 // Queue of recompilation tasks ready to be installed (excluding OSR). 144 // Queue of recompilation tasks ready to be installed (excluding OSR).
145 UnboundQueue<RecompileJob*> output_queue_; 145 UnboundQueue<OptimizedCompileJob*> output_queue_;
146 146
147 // Cyclic buffer of recompilation tasks for OSR. 147 // Cyclic buffer of recompilation tasks for OSR.
148 RecompileJob** osr_buffer_; 148 OptimizedCompileJob** osr_buffer_;
149 int osr_buffer_capacity_; 149 int osr_buffer_capacity_;
150 int osr_buffer_cursor_; 150 int osr_buffer_cursor_;
151 151
152 volatile AtomicWord stop_thread_; 152 volatile AtomicWord stop_thread_;
153 TimeDelta time_spent_compiling_; 153 TimeDelta time_spent_compiling_;
154 TimeDelta time_spent_total_; 154 TimeDelta time_spent_total_;
155 155
156 int osr_hits_; 156 int osr_hits_;
157 int osr_attempts_; 157 int osr_attempts_;
158 158
159 int blocked_jobs_; 159 int blocked_jobs_;
160 }; 160 };
161 161
162 } } // namespace v8::internal 162 } } // namespace v8::internal
163 163
164 #endif // V8_OPTIMIZING_COMPILER_THREAD_H_ 164 #endif // V8_OPTIMIZING_COMPILER_THREAD_H_
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/optimizing-compiler-thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698