Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1102023002: Call callback asynchronously for device reboot command (Closed)

Created:
5 years, 8 months ago by binjin
Modified:
5 years, 8 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remote-0420
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call callback asynchronously for device reboot command The remote command framework requires the remote job implementations to call the callback asynchronously. Post task to the message loop of current thread to fix this issue. BUG=480982 Committed: https://crrev.com/1777b8b7977c9dddb5f64fffb897a80ed58ebbdf Cr-Commit-Position: refs/heads/master@{#326789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
binjin
Please take a quick look at this one-line fix.
5 years, 8 months ago (2015-04-24 12:57:54 UTC) #2
bartfab (slow)
Please reference a bug number. Other than that, LGTM.
5 years, 8 months ago (2015-04-24 13:59:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102023002/1
5 years, 8 months ago (2015-04-24 14:06:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 14:20:29 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 14:21:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1777b8b7977c9dddb5f64fffb897a80ed58ebbdf
Cr-Commit-Position: refs/heads/master@{#326789}

Powered by Google App Engine
This is Rietveld 408576698