Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1101993003: Move common distiller code to superclass (Closed)

Created:
5 years, 8 months ago by mdjones
Modified:
5 years, 7 months ago
Reviewers:
nyquist
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move common distiller code to superclass This change moves any code related to JavaScript and HTML generation in dom distiller to a superclass that all platforms can use. BUG=472797 Committed: https://crrev.com/b9fee24969e63f6b172d62c6a26c56812cb3b697 Cr-Commit-Position: refs/heads/master@{#327055}

Patch Set 1 #

Patch Set 2 : cl format #

Total comments: 1

Patch Set 3 : Move IOS to different CL #

Total comments: 21

Patch Set 4 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -130 lines) Patch
M components/dom_distiller.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/dom_distiller/content/dom_distiller_viewer_source.cc View 1 2 3 9 chunks +42 lines, -130 lines 0 comments Download
M components/dom_distiller/core/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A components/dom_distiller/core/dom_distiller_request_view_base.h View 1 2 3 1 chunk +87 lines, -0 lines 0 comments Download
A components/dom_distiller/core/dom_distiller_request_view_base.cc View 1 2 3 1 chunk +115 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101993003/20001
5 years, 8 months ago (2015-04-24 16:04:01 UTC) #2
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 8 months ago (2015-04-24 16:04:02 UTC) #4
mdjones
5 years, 8 months ago (2015-04-24 16:28:45 UTC) #6
nyquist
https://codereview.chromium.org/1101993003/diff/20001/components/dom_distiller/core/dom_distiller_request_view_base.h File components/dom_distiller/core/dom_distiller_request_view_base.h (right): https://codereview.chromium.org/1101993003/diff/20001/components/dom_distiller/core/dom_distiller_request_view_base.h#newcode30 components/dom_distiller/core/dom_distiller_request_view_base.h:30: virtual void runCallback(std::string& data) = 0; could the param ...
5 years, 8 months ago (2015-04-24 22:13:09 UTC) #7
mdjones
https://codereview.chromium.org/1101993003/diff/40001/components/dom_distiller.gypi File components/dom_distiller.gypi (right): https://codereview.chromium.org/1101993003/diff/40001/components/dom_distiller.gypi#newcode85 components/dom_distiller.gypi:85: 'dom_distiller/core/dom_distiller_request_view_base.cc', On 2015/04/24 22:13:08, nyquist wrote: > Do you ...
5 years, 8 months ago (2015-04-25 00:55:03 UTC) #8
nyquist
lgtm https://codereview.chromium.org/1101993003/diff/40001/components/dom_distiller/core/dom_distiller_request_view_base.h File components/dom_distiller/core/dom_distiller_request_view_base.h (right): https://codereview.chromium.org/1101993003/diff/40001/components/dom_distiller/core/dom_distiller_request_view_base.h#newcode55 components/dom_distiller/core/dom_distiller_request_view_base.h:55: // ready. On 2015/04/25 00:55:03, mdjones wrote: > ...
5 years, 8 months ago (2015-04-25 03:15:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101993003/60001
5 years, 8 months ago (2015-04-27 15:38:30 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-04-27 16:41:02 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 16:41:52 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b9fee24969e63f6b172d62c6a26c56812cb3b697
Cr-Commit-Position: refs/heads/master@{#327055}

Powered by Google App Engine
This is Rietveld 408576698