Issue 1101993002: Fix adding to WeakFixedArray after compaction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1101993002: Fix adding to WeakFixedArray after compaction. (Closed)

Created:
5 years, 8 months ago by Yang

Modified:
5 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix adding to WeakFixedArray after compaction. WeakFixedArray::Add expects space for at least one element. R=jkummerow@chromium.org

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	src/objects.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	test/cctest/test-heap.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

5 years, 8 months ago (2015-04-24 10:59:56 UTC) #2

As discussed offline, I'll include the test in my next CL, where I've run into
the same issue, but am fixing it differently by making sure WeakFixedArrays can
be empty and still behave correctly.

Expand Messages | Collapse Messages