Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1101923002: mac: Suppress a clang warning in CustomFrameView. (Closed)

Created:
5 years, 8 months ago by erikchen
Modified:
5 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Suppress a clang warning in CustomFrameView. Clang's static analyzer emits the warning "-Wobjc-designated-initializers" for CustomFrameView, because CustomFrameView overrides two designated initializers, but the methods don't call super. The methods throw exceptions, which Clang's static analyzer isn't smart enough to catch. Declaring the methods with NS_UNAVAILABLE suppresses the clang warning. BUG= Committed: https://crrev.com/8f7b9f93a037437f09cc3d95aa73a6a8346df0af Cr-Commit-Position: refs/heads/master@{#329971}

Patch Set 1 #

Patch Set 2 : Switch to UNAVAILABLE_ATTRIBUTE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/custom_frame_view.mm View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
erikchen
rsesek: Please review.
5 years, 8 months ago (2015-04-23 22:12:14 UTC) #2
Robert Sesek
LGTM, much better.
5 years, 8 months ago (2015-04-23 22:12:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101923002/1
5 years, 8 months ago (2015-04-23 22:14:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/58764)
5 years, 8 months ago (2015-04-23 23:14:49 UTC) #7
erikchen
On 2015/04/23 23:14:49, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-04-23 23:17:12 UTC) #8
Robert Sesek
On 2015/04/23 23:17:12, erikchen wrote: > On 2015/04/23 23:14:49, I haz the power (commit-bot) wrote: ...
5 years, 8 months ago (2015-04-24 15:33:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101923002/20001
5 years, 7 months ago (2015-05-14 22:30:41 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 23:21:10 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 23:21:56 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f7b9f93a037437f09cc3d95aa73a6a8346df0af
Cr-Commit-Position: refs/heads/master@{#329971}

Powered by Google App Engine
This is Rietveld 408576698