Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1101913002: Try NtDuplicateObject instead of DuplicateHandle on Windows 8/8.1 for debugging AppContainer relate… (Closed)

Created:
5 years, 8 months ago by Shrikant Kelkar
Modified:
5 years, 8 months ago
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try NtDuplicateObject instead of DuplicateHandle on Windows 8/8.1 for debugging AppContainer related failures. This patch should be reverted as soon as we get some confirmation that NtDuplicateObject is working better compared to DuplicateHandle. Theory behind this patch is that it might be possible that on machines which reporting this find of failure have some software like AV which might be intercepting calls to DuplciateHandle and may be failing somewhere in intercepted code path due to AppContainer. Looking in IDA error code that we are receiving 0xC0000023 (Which translates INSUFFICIENT_BUFFER (0x7a) in win32 language) doesn't seem to be in NtDuplicateObject code path (At least not found easily.). BUG=468922 R=jschuh@chromium.org,cpu@chromium.org Committed: https://crrev.com/f7d692ca5448140fb21ffa42ca8b1535aae0b490 Cr-Commit-Position: refs/heads/master@{#326943}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -5 lines) Patch
M base/win/scoped_process_information.cc View 1 2 chunks +44 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Shrikant Kelkar
ptal.
5 years, 8 months ago (2015-04-23 21:40:25 UTC) #1
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/1101913002/diff/1/base/win/scoped_process_information.cc File base/win/scoped_process_information.cc (right): https://codereview.chromium.org/1101913002/diff/1/base/win/scoped_process_information.cc#newcode31 base/win/scoped_process_information.cc:31: typedef LONG NTSTATUS; just do LONG w/o typedef https://codereview.chromium.org/1101913002/diff/1/base/win/scoped_process_information.cc#newcode52 ...
5 years, 8 months ago (2015-04-24 02:39:56 UTC) #2
Shrikant Kelkar
https://codereview.chromium.org/1101913002/diff/1/base/win/scoped_process_information.cc File base/win/scoped_process_information.cc (right): https://codereview.chromium.org/1101913002/diff/1/base/win/scoped_process_information.cc#newcode31 base/win/scoped_process_information.cc:31: typedef LONG NTSTATUS; On 2015/04/24 02:39:56, cpu wrote: > ...
5 years, 8 months ago (2015-04-24 18:31:27 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
5 years, 8 months ago (2015-04-24 21:58:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101913002/20001
5 years, 8 months ago (2015-04-24 22:00:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-25 00:36:01 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 00:36:54 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f7d692ca5448140fb21ffa42ca8b1535aae0b490
Cr-Commit-Position: refs/heads/master@{#326943}

Powered by Google App Engine
This is Rietveld 408576698