Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1101883002: Suppress value changed events on text fields/text areas. (Closed)

Created:
5 years, 8 months ago by David Tseng
Modified:
5 years, 8 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress value changed events on text fields/text areas. When hitting enter while over a text field/text area, value changed events fire. This results in ChromeVox echoing the entire text field/text area again. Committed: https://crrev.com/a5de7e4efa6774cd8b24da3152e88077b8b63b82 Cr-Commit-Position: refs/heads/master@{#326680}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 2 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
David Tseng
5 years, 8 months ago (2015-04-23 17:50:59 UTC) #2
dmazzoni
lgtm
5 years, 8 months ago (2015-04-23 21:40:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101883002/20001
5 years, 8 months ago (2015-04-23 21:42:43 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 22:49:51 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 22:51:21 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a5de7e4efa6774cd8b24da3152e88077b8b63b82
Cr-Commit-Position: refs/heads/master@{#326680}

Powered by Google App Engine
This is Rietveld 408576698