Issue 1101853002: Revert of Add a WinHeap dump provider to the memory profiler.

Issue 1101853002: Revert of Add a WinHeap dump provider to the memory profiler. (Closed)

Created:
5 years, 8 months ago by jonross

Modified:
5 years, 8 months ago

Reviewers:
Primiano Tucci (use gerrit), Sébastien Marchand, nduca, chrisha

CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Add a WinHeap dump provider to the memory profiler. (patchset #2 id:40001 of https://codereview.chromium.org/1100173002/) Reason for revert: This change has broke the CQ build: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/240 Original issue's description: > Add a WinHeap dump provider to the memory profiler. > > BUG=466141 > > Committed: https://crrev.com/62215af64daf642c492fc2002cffc287b2c3bb09 > Cr-Commit-Position: refs/heads/master@{#326501} TBR=primiano@chromium.org,chrisha@chromium.org,nduca@chromium.org,sebmarchand@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466141 Committed: https://crrev.com/ae2b94f80638e441994b571efc61a4433c054caf Cr-Commit-Position: refs/heads/master@{#326503}

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -245 lines)			Patch
M	base/trace_event/memory_dump_manager.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	base/trace_event/trace_event.gypi	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	base/trace_event/winheap_dump_provider_win.h	View	1 chunk	+0 lines, -54 lines	0 comments	Download
D	base/trace_event/winheap_dump_provider_win.cc	View	1 chunk	+0 lines, -105 lines	0 comments	Download
D	base/trace_event/winheap_dump_provider_win_unittest.cc	View	1 chunk	+0 lines, -79 lines	0 comments	Download

Total messages: 5 (0 generated)

jonross

Created Revert of Add a WinHeap dump provider to the memory profiler.

5 years, 8 months ago (2015-04-23 13:52:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101853002/1

5 years, 8 months ago (2015-04-23 13:53:02 UTC) #2

Sébastien Marchand

Damn, I forgot to update the ng files... LGTM.

5 years, 8 months ago (2015-04-23 13:54:52 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-23 13:55:01 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ae2b94f80638e441994b571efc61a4433c054caf
Cr-Commit-Position: refs/heads/master@{#326503}