Updating modification time of parent when a folder node is added in it in bookmark bar.

chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/bookmarks/bookmarks_api.h"
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/i18n/file_util_icu.h"
 #include "base/i18n/time_formatting.h"
@@ skipping 171 matching lines @@
   const BookmarkNode* node;
   if (url_string.length())
     node = model->AddURLWithCreationTimeAndMetaInfo(
         parent, index, title, url, base::Time::Now(), meta_info);
   else
     node = model->AddFolderWithMetaInfo(parent, index, title, meta_info);
   DCHECK(node);
   if (!node) {
     error_ = keys::kNoNodeError;
     return NULL;
+  } else if (!details.url.get()) {
+    model->SetDateFolderModified(parent, base::Time::Now());

[Ken Rockot(use gerrit already), 2015/04/28 03:14:39]

This looks like the wrong code to change. Shouldn't you instead add a call to
parent->set_date_folder_modified from within
BookmarkModel::AddFolderWithMetaInfo?

On an tangential note, the if-block after the DCHECK is effectively unreachable
and should probably be removed.

[Deepak, 2015/04/28 11:23:33]

I have done changes due to 2 reasons:
1) I have followed the way parent node is getting modified when we add folders
via bookmark manager.
It is adding the folder node and then modifying the parent modification time in
BookmarkNode* CreateNewNode().

2)we should not modify parent folder time till new node get added in it. and
AddNode() called last in BookmarkModel::AddFolderWithMetaInfo().

Bookmark model is accessed by both bookmark bar as well as bookmark manager, so
does not wanted to disturb functionality here.

I agree with you that if condition is not reachable as DCHECK() is their.
I am removing this code and putting by code in the else case.

Please correct me if I misunderstood something.
Thanks

   }
 
   return node;
 }
 
 bool BookmarksFunction::EditBookmarksEnabled() {
   PrefService* prefs = user_prefs::UserPrefs::Get(GetProfile());
   if (prefs->GetBoolean(::bookmarks::prefs::kEditBookmarksEnabled))
     return true;
   error_ = keys::kEditBookmarksDisabled;
@@ skipping 643 matching lines @@
 }
 
 void BookmarksExportFunction::FileSelected(const base::FilePath& path,
                                            int index,
                                            void* params) {
   bookmark_html_writer::WriteBookmarks(GetProfile(), path, NULL);
   Release();  // Balanced in BookmarksIOFunction::SelectFile()
 }
 
 }  // namespace extensions