DevTools: added console warning when call to document.write() from async script is ignored

DevTools: added console warning when call to document.write() from async script is ignored

BUG=242325
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164310

[vsevik, 2013-12-23 12:16:56]

PTAL

[Mike West, 2013-12-23 16:08:15]

LGTM if you do two things:

1. Add a test that verifies the message is written out to the console.
2. Use the 'ExceptionMessages::failedToExecute' helper, as outlined in the
comment below.

https://codereview.chromium.org/110183005/diff/1/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/110183005/diff/1/Source/core/dom/Document.cpp...
Source/core/dom/Document.cpp:2562: addConsoleMessage(JSMessageSource,
WarningMessageLevel, "A call to document.write() from an asynchronously-loaded
external script was ignored.");
Please change this to use 'ExceptionMessages::failedToExecute'.

Something like 'ExceptionMessages::failedToExecute("write", "Document", "It
isn't possible to write into a document from an asynchronously-loaded external
script.");' or whatever sounds good to you; the important thing is to use the
helper method so that we're consistent in our messaging.

[vsevik, 2013-12-23 18:16:45]

PTAL

I am not 100% sure that failedToExecute usage is semantically correct here: this
is not an error, this is just warning. But I trust your opinion on that.

[Mike West, 2013-12-23 20:04:11]

On 2013/12/23 18:16:45, vsevik wrote:
> PTAL
> 
> I am not 100% sure that failedToExecute usage is semantically correct here:
this
> is not an error, this is just warning. But I trust your opinion on that.

Well, we're not writing the thing the developer asked us to write. That seems
more like a failure than a warning. I think the message makes sense. *shrug*

LGTM if you fix the unhappy bots. :)

[commit-bot: I haz the power, 2013-12-24 09:12:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vsevik@chromium.org/110183005/120001

[commit-bot: I haz the power, 2013-12-24 10:18:01]

Change committed as 164310