Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 110183002: Remove #if ENABLE(NAVIGATOR_CONTENT_UTILS) from blink (Closed)

Created:
7 years ago by gyuyoung-inactive
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove #if ENABLE(NAVIGATOR_CONTENT_UTILS) from blink r163413 and r239691 have supported a runtime enable flag for the navigator content utils. So, ENABLE(NAVIGATOR_CONTENT_UTILS) doesn't need to be exist anymore. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164486

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
M Source/build/features.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
gyuyoung-inactive
7 years ago (2013-12-09 11:29:56 UTC) #1
gyuyoung-inactive
On 2013/12/09 11:29:56, gyuyoung wrote: This cl should be landed after landing issue 104123003.
7 years ago (2013-12-09 11:36:10 UTC) #2
abarth-chromium
lgtm
7 years ago (2013-12-09 17:28:02 UTC) #3
gyuyoung-inactive
On 2013/12/09 17:28:02, abarth wrote: > lgtm Issue 104123003 just was landed. So, this turn ...
7 years ago (2013-12-10 07:15:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/110183002/1
7 years ago (2013-12-10 07:15:54 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=15047
7 years ago (2013-12-10 08:44:10 UTC) #6
gyuyoung-inactive
On 2013/12/10 08:44:10, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years ago (2013-12-11 16:48:53 UTC) #7
gyuyoung-inactive
On 2013/12/11 16:48:53, gyuyoung wrote: > On 2013/12/10 08:44:10, I haz the power (commit-bot) wrote: ...
7 years ago (2013-12-12 00:15:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/110183002/20001
6 years, 11 months ago (2014-01-04 14:07:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/110183002/120001
6 years, 11 months ago (2014-01-05 10:43:20 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 04:24:42 UTC) #11
Message was sent while issue was closed.
Change committed as 164486

Powered by Google App Engine
This is Rietveld 408576698