cc/layers/picture_layer_unittest.cc - Issue 1101823002: CC Animations: Make LayerAnimationController creation optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/picture_layer_unittest.cc

Issue 1101823002: CC Animations: Make LayerAnimationController creation optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Plumb LayerSettings parameter for cc::Layer construction. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/blink/web_layer_impl.cc ('K') | « cc/layers/picture_layer_impl_unittest.cc ('k') | cc/layers/scrollbar_layer_unittest.cc » ('j') | chrome/browser/android/compositor/layer/content_layer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/layers/picture_layer_unittest.cc

diff --git a/cc/layers/picture_layer_unittest.cc b/cc/layers/picture_layer_unittest.cc

index 917a36fefdd93f63a623781be570aa986d235cc6..9d2d13452d6073f4d5e6def3c4f95607c2d34092 100644

--- a/cc/layers/picture_layer_unittest.cc

+++ b/cc/layers/picture_layer_unittest.cc

@@ -36,7 +36,8 @@ class MockContentLayerClient : public ContentLayerClient {

TEST(PictureLayerTest, NoTilesIfEmptyBounds) {

MockContentLayerClient client;

- scoped_refptr<PictureLayer> layer = PictureLayer::Create(&client);

+ scoped_refptr<PictureLayer> layer =

+ PictureLayer::Create(LayerSettings(), &client);

layer->SetBounds(gfx::Size(10, 10));

FakeLayerTreeHostClient host_client(FakeLayerTreeHostClient::DIRECT_3D);

@@ -79,7 +80,8 @@ TEST(PictureLayerTest, NoTilesIfEmptyBounds) {

TEST(PictureLayerTest, SuitableForGpuRasterization) {

MockContentLayerClient client;

- scoped_refptr<PictureLayer> layer = PictureLayer::Create(&client);

+ scoped_refptr<PictureLayer> layer =

+ PictureLayer::Create(LayerSettings(), &client);

FakeLayerTreeHostClient host_client(FakeLayerTreeHostClient::DIRECT_3D);

scoped_ptr<FakeLayerTreeHost> host = FakeLayerTreeHost::Create(&host_client);

host->SetRootLayer(layer);

@@ -100,7 +102,8 @@ TEST(PictureLayerTest, UseTileGridSize) {

settings.default_tile_grid_size = gfx::Size(123, 123);

MockContentLayerClient client;

- scoped_refptr<PictureLayer> layer = PictureLayer::Create(&client);

+ scoped_refptr<PictureLayer> layer =

+ PictureLayer::Create(LayerSettings(), &client);

FakeLayerTreeHostClient host_client(FakeLayerTreeHostClient::DIRECT_3D);

scoped_ptr<FakeLayerTreeHost> host =

FakeLayerTreeHost::Create(&host_client, settings);

@@ -127,7 +130,8 @@ TEST(PictureLayerTest, NonMonotonicSourceFrameNumber) {

new TestSharedBitmapManager());

MockContentLayerClient client;

- scoped_refptr<FakePictureLayer> layer = FakePictureLayer::Create(&client);

+ scoped_refptr<FakePictureLayer> layer =

+ FakePictureLayer::Create(LayerSettings(), &client);

scoped_ptr<LayerTreeHost> host1 = LayerTreeHost::CreateSingleThreaded(

&host_client1, &host_client1, shared_bitmap_manager.get(), nullptr,