Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: lib/html/scripts/dartdomgenerator.py

Issue 11018012: Get rid of System class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/html/scripts/dartgenerator.py » ('j') | lib/html/scripts/systemhtml.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/scripts/dartdomgenerator.py
diff --git a/lib/html/scripts/dartdomgenerator.py b/lib/html/scripts/dartdomgenerator.py
index 497fce219965c3bd6e728fe4152077fdb0495657..cad63cf4f62fa47b52d99e86a41895d1b6ee6a9b 100755
--- a/lib/html/scripts/dartdomgenerator.py
+++ b/lib/html/scripts/dartdomgenerator.py
@@ -18,8 +18,8 @@ import sys
from generator import TypeRegistry
from htmlrenamer import HtmlRenamer
from systembase import GeneratorOptions
-from systemhtml import DartLibraryEmitter, HtmlInterfacesSystem,\
- Dart2JSBackend
+from systemhtml import DartLibraryEmitter, Dart2JSBackend,\
+ HtmlDartInterfaceGenerator, HtmlSystemShared
from systemnative import CPPLibraryEmitter, DartiumBackend
from templateloader import TemplateLoader
@@ -82,10 +82,16 @@ def GenerateFromDatabase(common_database, dart2js_output_dir,
template_loader, webkit_database, type_registry, renamer)
dart_library_emitter = DartLibraryEmitter(
emitters, dart_library_template, dart_output_dir)
- html_system = HtmlInterfacesSystem(
- options, dart_library_emitter, backend_factory)
+ shared_system = HtmlSystemShared(webkit_database)
Anton Muhin 2012/10/01 13:30:35 could it go into outer closure?
Anton Muhin 2012/10/01 13:30:35 shouldn't HtmlSystemShared be renamed into somethi
podivilov 2012/10/01 14:49:18 It's all about events now, I'm going to rename it
+
+ def generate_interface(interface):
+ backend = backend_factory(interface)
+ interface_generator = HtmlDartInterfaceGenerator(
Anton Muhin 2012/10/01 13:30:35 this is longer term, but the question: should it b
podivilov 2012/10/01 14:49:18 The instance is needed to store current interface
+ shared_system, options, dart_library_emitter, interface, backend)
+ interface_generator.Generate()
+
generator.Generate(
- webkit_database, html_system, common_database, _webkit_renames)
+ webkit_database, common_database, _webkit_renames, generate_interface)
dart_library_emitter.EmitLibrary(dart_library_path, auxiliary_dir)
if dart2js_output_dir:
« no previous file with comments | « no previous file | lib/html/scripts/dartgenerator.py » ('j') | lib/html/scripts/systemhtml.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698