Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1101793003: Expose minContentWidth/maxContentWidth and a callback for computing them. (Closed)

Created:
5 years, 8 months ago by ojan
Modified:
5 years, 8 months ago
Reviewers:
eseidel, Hixie
CC:
abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Expose minContentWidth/maxContentWidth and a callback for computing them. This exposes the last hooks needed to implement flexbox layout. For now, I didn't worry too much about the exact API we're exposing since this will all change with the upcoming redesign (e.g. https://codereview.chromium.org/1093633002). minContentWidth == the width if the element were to wrap at every wrapping point (not including border/padding) maxContentWidth == the width if the element were to only wrap at hard wrapping points (e.g. \n inside a whitespace: pre). R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/636e4b166e82f9751dc530d1f1547fa0e06edc9f

Patch Set 1 #

Patch Set 2 : make variable names consistent #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -62 lines) Patch
M sky/engine/core/dom/Element.h View 1 2 chunks +10 lines, -1 line 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 2 chunks +37 lines, -4 lines 0 comments Download
M sky/engine/core/dom/Element.idl View 2 chunks +3 lines, -1 line 2 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderCustomLayout.h View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderCustomLayout.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M sky/tests/layout/custom.sky View 4 chunks +84 lines, -53 lines 0 comments Download
M sky/tests/layout/custom-dirty-bits.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/layout/custom-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
5 years, 8 months ago (2015-04-23 02:08:26 UTC) #2
eseidel
lgtm https://codereview.chromium.org/1101793003/diff/20001/sky/engine/core/dom/Element.idl File sky/engine/core/dom/Element.idl (right): https://codereview.chromium.org/1101793003/diff/20001/sky/engine/core/dom/Element.idl#newcode51 sky/engine/core/dom/Element.idl:51: attribute double minContentWidth; // Intrinsic width if all ...
5 years, 8 months ago (2015-04-23 18:26:26 UTC) #3
ojan
https://codereview.chromium.org/1101793003/diff/20001/sky/engine/core/dom/Element.idl File sky/engine/core/dom/Element.idl (right): https://codereview.chromium.org/1101793003/diff/20001/sky/engine/core/dom/Element.idl#newcode51 sky/engine/core/dom/Element.idl:51: attribute double minContentWidth; // Intrinsic width if all wrappable ...
5 years, 8 months ago (2015-04-24 20:02:42 UTC) #4
ojan
5 years, 8 months ago (2015-04-24 20:14:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
636e4b166e82f9751dc530d1f1547fa0e06edc9f.

Powered by Google App Engine
This is Rietveld 408576698