Add Windows support.

test/runner/pub_serve_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 @TestOn("vm")
 
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:path/path.dart' as p;
@@ skipping 55 matching lines @@
     });
   }
 }
 """);
 
     var pubGetResult = runPub(['get'], workingDirectory: _sandbox);
     expect(pubGetResult.exitCode, equals(0));
   });
 
   tearDown(() {
+    // On Windows, there's no way to shut down the actual "pub serve" process.
+    // Killing the process we start will just kill the batch file wrapper (issue
+    // 23304), not the underlying "pub serve" process. Since that process has
+    // locks on files in the sandbox, we can't delete the sandbox on Windows
+    // without errors.
+    if (Platform.isWindows) return;
+
     new Directory(_sandbox).deleteSync(recursive: true);
   });
 
   group("with transformed tests", () {
     test("runs those tests in the VM", () {
       return startPub(['serve', '--port', '0'], workingDirectory: _sandbox)
           .then((process) {
         return _lines.bind(process.stdout)
             .firstWhere(_servingRegExp.hasMatch)
             .then((line) {
@@ skipping 65 matching lines @@
         return _lines.bind(process.stdout)
             .firstWhere(_servingRegExp.hasMatch)
             .then((line) {
           var match = _servingRegExp.firstMatch(line);
 
           try {
             var result = runTest(['--pub-serve=${match[1]}'],
                 workingDirectory: _sandbox);
             expect(result.stdout, allOf([
               contains('-1: load error'),
-              contains('Failed to load "test/my_test.dart":'),
+              contains('Failed to load "${p.join("test", "my_test.dart")}":'),
               contains('404 Not Found'),
               contains('Make sure "pub serve" is serving the test/ directory.')
             ]));
             expect(result.exitCode, equals(1));
           } finally {
             process.kill();
           }
         });
       });
     });
 
     test("gracefully handles pub serve running on the wrong directory for "
         "browser tests", () {
       new Directory(p.join(_sandbox, "web")).createSync();
 
       return startPub(['serve', '--port', '0', 'web'],
               workingDirectory: _sandbox)
           .then((process) {
         return _lines.bind(process.stdout)
             .firstWhere(_servingRegExp.hasMatch)
             .then((line) {
           var match = _servingRegExp.firstMatch(line);
 
           try {
             var result = runTest(
                 ['--pub-serve=${match[1]}', '-p', 'chrome'],
                 workingDirectory: _sandbox);
             expect(result.stdout, allOf([
               contains('-1: load error'),
-              contains('Failed to load "test/my_test.dart":'),
+              contains('Failed to load "${p.join("test", "my_test.dart")}":'),
               contains('404 Not Found'),
               contains('Make sure "pub serve" is serving the test/ directory.')
             ]));
             expect(result.exitCode, equals(1));
           } finally {
             process.kill();
           }
         });
       });
     });
@@ skipping 104 matching lines @@
       });
     });
   });
 
   test("gracefully handles pub serve not running for VM tests", () {
     var result = runTest(['--pub-serve=54321'],
         workingDirectory: _sandbox);
     expect(result.stdout, allOf([
       contains('-1: load error'),
       contains('''
-  Failed to load "test/my_test.dart":
+  Failed to load "${p.join("test", "my_test.dart")}":
   Error getting http://localhost:54321/my_test.dart.vm_test.dart: Connection refused
   Make sure "pub serve" is running.''')
     ]));
     expect(result.exitCode, equals(1));
   });
 
   test("gracefully handles pub serve not running for browser tests", () {
     var result = runTest(['--pub-serve=54321', '-p', 'chrome'],
         workingDirectory: _sandbox);
+    var message = Platform.isWindows
+        ? 'The remote computer refused the network connection.'
+        : 'Connection refused (errno ';
+
     expect(result.stdout, allOf([
       contains('-1: load error'),
-      contains('Failed to load "test/my_test.dart":'),
+      contains('Failed to load "${p.join("test", "my_test.dart")}":'),
       contains('Error getting http://localhost:54321/my_test.dart.browser_test'
-          '.dart.js: Connection refused (errno '),
+          '.dart.js: $message'),
       contains('Make sure "pub serve" is running.')
     ]));
     expect(result.exitCode, equals(1));
   });
 
   test("gracefully handles a test file not being in test/", () {
     new File(p.join(_sandbox, 'test/my_test.dart'))
         .copySync(p.join(_sandbox, 'my_test.dart'));
 
     var result = runTest(['--pub-serve=54321', 'my_test.dart'],
         workingDirectory: _sandbox);
     expect(result.stdout, allOf([
       contains('-1: load error'),
       contains(
           'Failed to load "my_test.dart": When using "pub serve", all test '
               'files must be in test/.\n')
     ]));
     expect(result.exitCode, equals(1));
   });
 }