Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 1101763002: Update {virtual,override} to follow C++11 style in chromeos. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
hashimoto, zel
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in chromeos. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/e81b3346126a4f586992ed502256eba5b43f1e19 Cr-Commit-Position: refs/heads/master@{#326453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chromeos/dbus/nfc_client_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/shill_client_unittest_base.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ncarter (slow)
zelidrag: please review
5 years, 8 months ago (2015-04-23 04:21:01 UTC) #2
hashimoto
lgtm
5 years, 8 months ago (2015-04-23 04:22:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101763002/1
5 years, 8 months ago (2015-04-23 04:39:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 04:43:24 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 04:44:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e81b3346126a4f586992ed502256eba5b43f1e19
Cr-Commit-Position: refs/heads/master@{#326453}

Powered by Google App Engine
This is Rietveld 408576698