Put the screenshot URI in clipData

Put the screenshot URI in clipData

Adding Intent.FLAG_GRANT_READ_URI_PERMISSION only worked on specifit URIs
(EXTRA_STREAM, or MULTIPLE_STREAM).

So the URI should be put in ClipData to give read access to an Intent
target.

BUG=480047
Committed: https://crrev.com/0810f2fa93ea42181ad9628184246aed8efb8008
Cr-Commit-Position: refs/heads/master@{#326701}

[Jaekyun Seok (inactive), 2015-04-23 01:28:55]

jaekyun@chromium.org changed reviewers:
+ aurimas@chromium.org, tedchoc@chromium.org

[Jaekyun Seok (inactive), 2015-04-23 01:28:55]

aurimas@ and tedchoc@, please review this CL.

[Ted C, 2015-04-23 20:44:05]

https://codereview.chromium.org/1101743003/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/1101743003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:258:
intent.putExtra(EXTRA_SHARE_SCREENSHOT_AS_STREAM, screenshotUri);
do we need this extra still?

What will end users need to do here?

intent.getClipData() or will they still be using the extra?

[Jaekyun Seok (inactive), 2015-04-23 20:46:22]

https://codereview.chromium.org/1101743003/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/1101743003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:258:
intent.putExtra(EXTRA_SHARE_SCREENSHOT_AS_STREAM, screenshotUri);
On 2015/04/23 20:44:05, Ted C wrote:
> do we need this extra still?
> 
> What will end users need to do here?
> 
> intent.getClipData() or will they still be using the extra?

They will use the extra. This is to give read access to the URL.

[Ted C, 2015-04-23 20:50:06]

lgtm

https://codereview.chromium.org/1101743003/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/1101743003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:258:
intent.putExtra(EXTRA_SHARE_SCREENSHOT_AS_STREAM, screenshotUri);
On 2015/04/23 20:46:22, Jaekyun Seok wrote:
> On 2015/04/23 20:44:05, Ted C wrote:
> > do we need this extra still?
> > 
> > What will end users need to do here?
> > 
> > intent.getClipData() or will they still be using the extra?
> 
> They will use the extra. This is to give read access to the URL.

Can you add a comment about that?  It looks unnecessary and would be easy for
someone to think it could be removed.

[Jaekyun Seok (inactive), 2015-04-23 23:57:50]

https://codereview.chromium.org/1101743003/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/1101743003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:258:
intent.putExtra(EXTRA_SHARE_SCREENSHOT_AS_STREAM, screenshotUri);
On 2015/04/23 20:50:06, Ted C wrote:
> On 2015/04/23 20:46:22, Jaekyun Seok wrote:
> > On 2015/04/23 20:44:05, Ted C wrote:
> > > do we need this extra still?
> > > 
> > > What will end users need to do here?
> > > 
> > > intent.getClipData() or will they still be using the extra?
> > 
> > They will use the extra. This is to give read access to the URL.
> 
> Can you add a comment about that?  It looks unnecessary and would be easy for
> someone to think it could be removed.

Done.

[Jaekyun Seok (inactive), 2015-04-23 23:57:58]

The CQ bit was checked by jaekyun@chromium.org

[Jaekyun Seok (inactive), 2015-04-23 23:57:58]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1101743003/#ps40001
(title: "Add comments")

[commit-bot: I haz the power, 2015-04-23 23:58:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1101743003/40001

[commit-bot: I haz the power, 2015-04-24 00:24:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-24 00:26:35]

Patchset 3 (id:??) landed as
https://crrev.com/0810f2fa93ea42181ad9628184246aed8efb8008
Cr-Commit-Position: refs/heads/master@{#326701}