Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1101733005: CacheStorage: Merge CacheStorageListener into CacheStorageDispatcherHost (1) (Closed)

Created:
5 years, 8 months ago by nhiroki
Modified:
5 years, 8 months ago
Reviewers:
jsbell
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CacheStorage: Merge CacheStorageListener into CacheStorageDispatcherHost (1) CacheStorageListener and CacheStorageDispatcher are now in a 1:1 relationship and the indirection is no longer necessary. As a first step of merge, this CL moves message handlers for CacheStorage API from the listener to the dispatcher. BUG=474233 TEST=content_unittests --gtest_filter=CacheStorage* Committed: https://crrev.com/34cbfce4cae255c11fb19059ea4a31166768cdcf Cr-Commit-Position: refs/heads/master@{#327199}

Patch Set 1 : #

Patch Set 2 : add TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -236 lines) Patch
M content/browser/cache_storage/cache_storage_dispatcher_host.h View 2 chunks +46 lines, -0 lines 0 comments Download
M content/browser/cache_storage/cache_storage_dispatcher_host.cc View 4 chunks +229 lines, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_listener.h View 3 chunks +2 lines, -44 lines 0 comments Download
M content/browser/cache_storage/cache_storage_listener.cc View 1 4 chunks +3 lines, -191 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
nhiroki
Hi, can you review this? Thanks.
5 years, 8 months ago (2015-04-27 06:06:31 UTC) #8
jsbell
lgtm Thanks for picking this up! Normally we'd want TODOs explaining why there is temporary ...
5 years, 8 months ago (2015-04-27 23:15:39 UTC) #9
nhiroki
On 2015/04/27 23:15:39, jsbell wrote: > lgtm > > Thanks for picking this up! Normally ...
5 years, 8 months ago (2015-04-27 23:42:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101733005/140001
5 years, 8 months ago (2015-04-27 23:43:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:140001)
5 years, 8 months ago (2015-04-28 00:50:29 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/34cbfce4cae255c11fb19059ea4a31166768cdcf Cr-Commit-Position: refs/heads/master@{#327199}
5 years, 8 months ago (2015-04-28 00:52:04 UTC) #15
pdr.
On 2015/04/28 at 00:52:04, commit-bot wrote: > Patchset 2 (id:??) landed as https://crrev.com/34cbfce4cae255c11fb19059ea4a31166768cdcf > Cr-Commit-Position: ...
5 years, 8 months ago (2015-04-28 04:00:31 UTC) #16
pdr.
5 years, 8 months ago (2015-04-28 04:00:42 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:140001) has been created in
https://codereview.chromium.org/1111703002/ by pdr@chromium.org.

The reason for reverting is: I think this patch caused layouttest failures on
the Blink tree, see crbug.com/481784 for details..

Powered by Google App Engine
This is Rietveld 408576698