Issue 110173004: Introduces the notifier id for multi-profile notifications.

Issue 110173004: Introduces the notifier id for multi-profile notifications. (Closed)

Created:
7 years ago by Jun Mukai

Modified:
7 years ago

Reviewers:
xiyuan, stevenjb

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Introduces the notifier id for multi-profile notifications. Also this CL fixes notification delegate to invoke 'OnDismissed' when the notification is really dismissed. BUG=327033 R=xiyuan@chromium.org, stevenjb@chromium.org TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239727

Patch Set 2 : fix #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -2 lines)			Patch
M	ash/system/system_notifier.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/system_notifier.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/multi_profile_first_run_notification.cc	View	1	3 chunks	+30 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

xiyuan

LGTM Thanks. https://codereview.chromium.org/110173004/diff/1/chrome/browser/chromeos/login/multi_profile_first_run_notification.cc File chrome/browser/chromeos/login/multi_profile_first_run_notification.cc (right): https://codereview.chromium.org/110173004/diff/1/chrome/browser/chromeos/login/multi_profile_first_run_notification.cc#newcode33 chrome/browser/chromeos/login/multi_profile_first_run_notification.cc:33: MultiProfileFirstRunNotificationDelegate(base::Closure callback) nit: const base::Closure&

7 years ago (2013-12-09 19:54:00 UTC) #2

stevenjb

lgtm w/nits https://codereview.chromium.org/110173004/diff/1/chrome/browser/chromeos/login/multi_profile_first_run_notification.cc File chrome/browser/chromeos/login/multi_profile_first_run_notification.cc (right): https://codereview.chromium.org/110173004/diff/1/chrome/browser/chromeos/login/multi_profile_first_run_notification.cc#newcode33 chrome/browser/chromeos/login/multi_profile_first_run_notification.cc:33: MultiProfileFirstRunNotificationDelegate(base::Closure callback) explicit Also, maybe name 'user_close_callback'?

7 years ago (2013-12-09 20:18:52 UTC) #3

Jun Mukai

https://codereview.chromium.org/110173004/diff/1/chrome/browser/chromeos/login/multi_profile_first_run_notification.cc File chrome/browser/chromeos/login/multi_profile_first_run_notification.cc (right): https://codereview.chromium.org/110173004/diff/1/chrome/browser/chromeos/login/multi_profile_first_run_notification.cc#newcode33 chrome/browser/chromeos/login/multi_profile_first_run_notification.cc:33: MultiProfileFirstRunNotificationDelegate(base::Closure callback) On 2013/12/09 19:54:01, xiyuan wrote: > nit: ...

7 years ago (2013-12-09 21:23:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/110173004/20001

7 years ago (2013-12-09 21:41:04 UTC) #5

Message was sent while issue was closed.

Change committed as 239727

Expand Messages | Collapse Messages