DescriptionRevert "Intercept base::File Open/Close"
This reverts commit 45a0dc0b75b52e026eb15526ef441edc5dbe9ba5.
> Intercept base::File Open/Close
>
> When a file descriptor is opened by the base::File, all calls to close(3) from
> the same dynamic library will hit a CHECK unless they are made from a
> whitelist of callsites belonging to base::File.
>
> There is a handy protect_file_posix.gypi introduced to make it easy to enable
> on Chrome-for-Android.
>
> This 'linker magic' is somewhat crazy, so:
> 1. it will be *removed *when crbug.com/424562 is fixed
> 2. it should only be used by a whitelist of binaries/libraries (in the
> opensource part: libchromeshell only)
>
> BUG=424562
>
> Review URL: https://codereview.chromium.org/676873004
>
> Cr-Commit-Position: refs/heads/master@{#304592}
Reason: crashes are not numerous, not much sense to fix, some explanations found
elsewhere.
BUG=424562
Committed: https://crrev.com/e1ceecf5545568261956de95fda59270a91d4ef0
Cr-Commit-Position: refs/heads/master@{#327051}
Patch Set 1 #
Messages
Total messages: 14 (5 generated)
|