Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 11017068: Fix name of 32-bit nexes to make create_nmf happy (Closed)

Created:
8 years, 2 months ago by Sam Clegg
Modified:
8 years, 2 months ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Fix name of 32-bit nexes to make create_nmf happy. Unfortunetely the current version of create_nmf requires that 32-bit and 64-bit newlib nexes end with _32 and _64 respectively. Prior to this change the VS addin was calling the 32-bit ones _i686.nexe. BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1443

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 2 (0 generated)
Sam Clegg
Hopefully the last bug fix needed for the public release. (at least by last fix ...
8 years, 2 months ago (2012-10-11 00:28:16 UTC) #1
binji
8 years, 2 months ago (2012-10-11 00:32:50 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698