Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 11017022: Revert r13286 "Fix issues with test.dart that appeared on Mac." (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | tools/testing/dart/test_runner.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_progress.dart
===================================================================
--- tools/testing/dart/test_progress.dart (revision 13378)
+++ tools/testing/dart/test_progress.dart (working copy)
@@ -86,7 +86,7 @@
_printTimingInformation();
stdout.close();
stderr.close();
- exit(_failedTests > 0 ? 1 : 0);
+ if (_failedTests > 0) exit(1);
gram 2012/10/08 22:34:08 Did you intend to make this change? It seems the o
Emily Fortuna 2012/10/08 22:37:23 Yes, this was intentional. As mentioned in the com
}
void _printStartProgress(TestCase test) {}
@@ -220,9 +220,7 @@
void _printStartProgress(TestCase test) { }
void _printDoneProgress(TestCase test) { }
void allTestsKnown() { }
- void allDone() {
- exit(0);
- }
+ void allDone() { }
}
abstract class CompactIndicator extends ProgressIndicator {
@@ -240,7 +238,7 @@
}
stdout.close();
stderr.close();
- exit(_failedTests > 0 ? 1 : 0);
+ if (_failedTests > 0) exit(1);
gram 2012/10/08 22:34:08 Ditto
}
void allTestsKnown() {
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | tools/testing/dart/test_runner.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698