Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1101683002: Add an --omit-quit flag to d8 for Emscripten's sake. (Closed)

Created:
5 years, 8 months ago by Sven Panne
Modified:
5 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add an --omit-quit flag to d8 for Emscripten's sake. Committed: https://crrev.com/9bb8b58549d543bacc230b4094ff5c196fa61ad3 Cr-Commit-Position: refs/heads/master@{#28004}

Patch Set 1 #

Patch Set 2 : Revert SKIP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M src/d8.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/d8.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tools/run-tests.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 8 months ago (2015-04-22 11:58:00 UTC) #2
Michael Achenbach
lgtm
5 years, 8 months ago (2015-04-22 12:00:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101683002/20001
5 years, 8 months ago (2015-04-22 12:04:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-22 12:24:34 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 13:19:34 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bb8b58549d543bacc230b4094ff5c196fa61ad3
Cr-Commit-Position: refs/heads/master@{#28004}

Powered by Google App Engine
This is Rietveld 408576698