Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1101663006: Update {virtual,override} to follow C++11 style in win8. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in win8. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/68fbc356f2cd540da8e65cd1896043c7b4e7d3cb Cr-Commit-Position: refs/heads/master@{#326578}

Patch Set 1 #

Patch Set 2 : Reformat for reviewability #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -76 lines) Patch
M win8/metro_driver/chrome_app_view_ash.h View 2 chunks +5 lines, -5 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M win8/metro_driver/file_picker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M win8/metro_driver/file_picker_ash.h View 3 chunks +3 lines, -3 lines 0 comments Download
M win8/metro_driver/ime/input_source.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M win8/metro_driver/ime/text_service.cc View 1 6 chunks +8 lines, -9 lines 0 comments Download
M win8/metro_driver/metro_driver_win7.cc View 1 11 chunks +45 lines, -46 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.h View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
grt: please review this boring, boring change
5 years, 8 months ago (2015-04-23 04:14:57 UTC) #2
grt (UTC plus 2)
i laughed, i cried. it was better than cats. lgtm.
5 years, 8 months ago (2015-04-23 17:53:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101663006/20001
5 years, 8 months ago (2015-04-23 18:00:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 18:10:54 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 18:12:41 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68fbc356f2cd540da8e65cd1896043c7b4e7d3cb
Cr-Commit-Position: refs/heads/master@{#326578}

Powered by Google App Engine
This is Rietveld 408576698