Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1101633003: Roll Android SDK and AppCompat. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
Reviewers:
cjhopman, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll Android SDK and AppCompat. - Android SDK rolls to API 22 rev 2 (no API changes, just bug fixes) - Android Support Library rolls to 22.1.0 BUG=479858 Committed: https://crrev.com/a068236fabb7a1925df7494bd668c2b58b26979a Cr-Commit-Position: refs/heads/master@{#326437}

Patch Set 1 #

Patch Set 2 : fix GN madness with utf-8 \u2019 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/process_resources.py View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
aurimas (slooooooooow)
PTAL
5 years, 8 months ago (2015-04-22 21:13:57 UTC) #2
newt (away)
lgtm
5 years, 8 months ago (2015-04-22 21:21:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101633003/1
5 years, 8 months ago (2015-04-22 21:25:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/80742)
5 years, 8 months ago (2015-04-22 23:52:40 UTC) #7
aurimas (slooooooooow)
cjhopman: PTAL
5 years, 8 months ago (2015-04-23 00:48:41 UTC) #9
cjhopman
lgtm
5 years, 8 months ago (2015-04-23 00:49:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101633003/20001
5 years, 8 months ago (2015-04-23 00:51:04 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 02:57:03 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a068236fabb7a1925df7494bd668c2b58b26979a Cr-Commit-Position: refs/heads/master@{#326437}
5 years, 8 months ago (2015-04-23 02:58:02 UTC) #15
azarchs
5 years, 8 months ago (2015-04-23 09:31:23 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1092843003/ by azarchs@chromium.org.

The reason for reverting is: Breaks downstream Chrome Android ToT
instrumentation test.

crbug/480285.

Powered by Google App Engine
This is Rietveld 408576698