remoting/webapp/crd/js/crd_event_handlers.js - Issue 1101613003: [Webapp Refactor] Reliably cancels a connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/crd_event_handlers.js

Issue 1101613003: [Webapp Refactor] Reliably cancels a connection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ImproveUnittest

Patch Set: Reviewer's feedback Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/webapp/base/js/modal_dialogs.js ('K') | « remoting/webapp/crd/js/client_session_unittest.js ('k') | remoting/webapp/crd/js/desktop_remoting.js » ('j') | remoting/webapp/crd/js/me2me_activity.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/webapp/crd/js/crd_event_handlers.js

diff --git a/remoting/webapp/crd/js/crd_event_handlers.js b/remoting/webapp/crd/js/crd_event_handlers.js

index 01439faba5d1d73810c7a05f5e88146f9ac8520d..782004da3814a6b3706310e1f4de0e9a6d5214d9 100644

--- a/remoting/webapp/crd/js/crd_event_handlers.js

+++ b/remoting/webapp/crd/js/crd_event_handlers.js

@@ -11,13 +11,6 @@ remoting.initElementEventHandlers = function() {

var goHome = function() {

remoting.setMode(remoting.AppMode.HOME);

};

- var goFinishedIT2Me = function() {

- if (remoting.currentMode == remoting.AppMode.CLIENT_CONNECT_FAILED_IT2ME) {

- remoting.setMode(remoting.AppMode.CLIENT_UNCONNECTED);

- } else {

- goHome();

- }

- };

/** @type {Array<{event: string, id: string, fn: function(Event):void}>} */

var it2me_actions = [

{ event: 'click', id: 'cancel-share-button', fn: remoting.cancelShare },

@@ -44,7 +37,6 @@ remoting.initElementEventHandlers = function() {

];

/** @type {Array<{event: string, id: string, fn: function(Event):void}>} */

var auth_actions = [

- { event: 'click', id: 'cancel-connect-button', fn: goHome },

{ event: 'click', id: 'sign-out', fn:remoting.signOut },

{ event: 'click', id: 'token-refresh-error-ok', fn: goHome },

{ event: 'click', id: 'token-refresh-error-sign-in',