remoting/webapp/crd/js/client_session.js - Issue 1101613003: [Webapp Refactor] Reliably cancels a connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/client_session.js

Issue 1101613003: [Webapp Refactor] Reliably cancels a connection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ImproveUnittest

Patch Set: Reviewer's feedback Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/webapp/base/js/modal_dialogs.js ('K') | « remoting/webapp/base/js/modal_dialogs.js ('k') | remoting/webapp/crd/js/client_session_unittest.js » ('j') | remoting/webapp/crd/js/me2me_activity.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/webapp/crd/js/client_session.js

diff --git a/remoting/webapp/crd/js/client_session.js b/remoting/webapp/crd/js/client_session.js

index 8a6bdb870f63bcd1b15258e48dc3c7dd16452a25..01d1fc3c347ecadedfaeca2e9803e50fa44921b1 100644

--- a/remoting/webapp/crd/js/client_session.js

+++ b/remoting/webapp/crd/js/client_session.js

@@ -285,6 +285,10 @@ remoting.ClientSession.prototype.connect = function(host, credentialsProvider) {

* @return {void} Nothing.

remoting.ClientSession.prototype.disconnect = function(error) {

+ if (this.isFinished()) {

+ return;

+ }

this.sendIq_(

'<cli:iq ' +

'to="' + this.host_.jabberId + '" ' +