[Webapp Refactor] Reliably cancels a connection.

remoting/webapp/crd/js/client_session_unittest.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 
 'use strict';
 
 /** @type {remoting.MockConnection} */
 var mockConnection;
 /** @type {remoting.ClientSession} */
 var session;
 /** @type {remoting.ClientSession.EventHandler} */
 var listener;
 /** @type {sinon.TestStub} */
 var logToServerStub;
 /**
  * @constructor
  * @implements {remoting.ClientSession.EventHandler}
  */
 var SessionListener = function() {};
 SessionListener.prototype.onConnectionFailed = function(error) {};
 SessionListener.prototype.onConnected = function(connectionInfo) {};
-SessionListener.prototype.onDisconnected = function() {};
-SessionListener.prototype.onError = function(error) {};
+SessionListener.prototype.onDisconnected = function(error) {};
 
 /** @return {Promise} */
 function connect() {
   var deferred = new base.Deferred();
   var host = new remoting.Host('hostId');
   host.jabberId = 'jid';
 
   session.connect(host, new remoting.CredentialsProvider({
     pairingInfo: { clientId: 'clientId', sharedSecret: 'secret' }
   }));
@@ skipping 85 matching lines @@
     var onDisconnected = sinon.stub(listener, 'onDisconnected');
     session.disconnect(remoting.Error.none());
     assert.equal(onDisconnected.callCount, 1);
   });
 });
 
 QUnit.test(
   'Connection error after CONNECTED should raise the CONNECTION_DROPPED event',
   function(assert) {
   return connect().then(function() {
-    var onError = sinon.stub(listener, 'onError');
+    var onDisconnected = sinon.stub(listener, 'onDisconnected');
     session.disconnect(new remoting.Error(remoting.Error.Tag.P2P_FAILURE));
-    assert.equal(onError.callCount, 1);
+    assert.equal(onDisconnected.callCount, 1);
     assert.equal(logToServerStub.args[2][0],
                  remoting.ClientSession.State.CONNECTION_DROPPED);
   });
 });
 
 QUnit.test(
   'Connection error before CONNECTED should raise the CONNECTION_FAILED event',
   function(assert) {
 
   session.logHostOfflineErrors(true);
@@ skipping 14 matching lines @@
   });
 });
 
 QUnit.test('dispose() should dispose the plugin', function(assert) {
   var pluginDispose = sinon.stub(mockConnection.plugin(), 'dispose');
   session.dispose();
   assert.equal(pluginDispose.callCount, 1);
 });
 
 })();