Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 11016031: PNaCl: Use the PPAPI shims library on all architectures (Closed)

Created:
8 years, 2 months ago by Mark Seaborn
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, bradn
Visibility:
Public.

Description

PNaCl: Use the PPAPI shims library on all architectures In NaCl-side changes, the sandboxed translator has been changed to link the shims library on all architectures. (The shims library is defined on all architectures, if only as a dummy in some cases.) We need to change the translator extension to match. BUG=http://code.google.com/p/nativeclient/issues/detail?id=3018 TEST=PNaCl tests on *_naclmore trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159938

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M ppapi/native_client/src/untrusted/pnacl_support_extension/nacl.scons View 1 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
This change is needed to unblock the nacl_revision update in http://codereview.chromium.org/11049007/ -- see the mac_rel_naclmore ...
8 years, 2 months ago (2012-10-03 17:52:08 UTC) #1
jvoung (off chromium)
lgtm https://codereview.chromium.org/11016031/diff/1/ppapi/native_client/src/untrusted/pnacl_support_extension/nacl.scons File ppapi/native_client/src/untrusted/pnacl_support_extension/nacl.scons (right): https://codereview.chromium.org/11016031/diff/1/ppapi/native_client/src/untrusted/pnacl_support_extension/nacl.scons#newcode15 ppapi/native_client/src/untrusted/pnacl_support_extension/nacl.scons:15: # Otherwise, there may be a mismatch between ...
8 years, 2 months ago (2012-10-03 18:11:18 UTC) #2
Mark Seaborn
8 years, 2 months ago (2012-10-03 18:56:15 UTC) #3
https://codereview.chromium.org/11016031/diff/1/ppapi/native_client/src/untru...
File ppapi/native_client/src/untrusted/pnacl_support_extension/nacl.scons
(right):

https://codereview.chromium.org/11016031/diff/1/ppapi/native_client/src/untru...
ppapi/native_client/src/untrusted/pnacl_support_extension/nacl.scons:15: #
Otherwise, there may be a mismatch between the latest pepper headers
On 2012/10/03 18:11:19, jvoung (chromium) wrote:
> Unrelated, but if you want, you can also reword this comment about pepper
> headers and the "toolchain tarball".  The shim isn't in the toolchain tarball
> anymore.  Something like:
> 
> # Override the IRT shim with the latest one built in scons-out.
> # It is the version that matches the current version of pepper.

Done.

Powered by Google App Engine
This is Rietveld 408576698