Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2534)

Unified Diff: chrome/browser/ui/browser.h

Issue 11016023: Quickly close tabs/window with long-running unload handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Patch for landing Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index a8f7331a6ab3d7de34c8e98edf232bba6b376642..808ffa100ffe99e92b29719136f05025de5fcb7a 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -293,6 +293,13 @@ class Browser : public TabStripModelObserver,
// Gives beforeunload handlers the chance to cancel the close.
bool ShouldCloseWindow();
+ // Figure out if there are tabs that have beforeunload handlers.
+ // It starts beforeunload/unload processing as a side-effect.
+ bool TabsNeedBeforeUnloadFired();
+
+ // Returns true if all tabs' beforeunload/unload events have fired.
+ bool HasCompletedUnloadProcessing() const;
+
bool IsAttemptingToCloseBrowser() const;
// Invoked when the window containing us is closing. Performs the necessary
@@ -430,9 +437,6 @@ class Browser : public TabStripModelObserver,
content::WebContents* source,
const content::NativeWebKeyboardEvent& event) OVERRIDE;
- // Figure out if there are tabs that have beforeunload handlers.
- bool TabsNeedBeforeUnloadFired();
-
bool is_type_tabbed() const { return type_ == TYPE_TABBED; }
bool is_type_popup() const { return type_ == TYPE_POPUP; }
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698