Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6846)

Unified Diff: chrome/browser/ui/browser.cc

Issue 11016023: Quickly close tabs/window with long-running unload handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Patch for landing Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index c18459905f6005a4e92cec5382f889767a883a07..539639ae30019db2103e97fcdd5e230f8c53132a 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -586,6 +586,14 @@ bool Browser::ShouldCloseWindow() {
return unload_controller_->ShouldCloseWindow();
}
+bool Browser::TabsNeedBeforeUnloadFired() {
+ return unload_controller_->TabsNeedBeforeUnloadFired();
+}
+
+bool Browser::HasCompletedUnloadProcessing() const {
+ return unload_controller_->HasCompletedUnloadProcessing();
+}
+
bool Browser::IsAttemptingToCloseBrowser() const {
return unload_controller_->is_attempting_to_close_browser();
}
@@ -629,8 +637,6 @@ void Browser::OnWindowClosing() {
chrome::NOTIFICATION_BROWSER_CLOSING,
content::Source<Browser>(this),
content::NotificationService::NoDetails());
-
- tab_strip_model_->CloseAllTabs();
}
////////////////////////////////////////////////////////////////////////////////
@@ -1167,10 +1173,6 @@ void Browser::HandleKeyboardEvent(content::WebContents* source,
window()->HandleKeyboardEvent(event);
}
-bool Browser::TabsNeedBeforeUnloadFired() {
- return unload_controller_->TabsNeedBeforeUnloadFired();
-}
-
bool Browser::IsMouseLocked() const {
return fullscreen_controller_->IsMouseLocked();
}
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698