Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 11016023: Quickly close tabs/window with long-running unload handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make UnloadDetachedHandler a delegate for all detached tabs. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 243
244 virtual const std::string& GetContentsMimeType() const OVERRIDE; 244 virtual const std::string& GetContentsMimeType() const OVERRIDE;
245 virtual bool WillNotifyDisconnection() const OVERRIDE; 245 virtual bool WillNotifyDisconnection() const OVERRIDE;
246 virtual void SetOverrideEncoding(const std::string& encoding) OVERRIDE; 246 virtual void SetOverrideEncoding(const std::string& encoding) OVERRIDE;
247 virtual void ResetOverrideEncoding() OVERRIDE; 247 virtual void ResetOverrideEncoding() OVERRIDE;
248 virtual RendererPreferences* GetMutableRendererPrefs() OVERRIDE; 248 virtual RendererPreferences* GetMutableRendererPrefs() OVERRIDE;
249 virtual void SetNewTabStartTime(const base::TimeTicks& time) OVERRIDE; 249 virtual void SetNewTabStartTime(const base::TimeTicks& time) OVERRIDE;
250 virtual base::TimeTicks GetNewTabStartTime() const OVERRIDE; 250 virtual base::TimeTicks GetNewTabStartTime() const OVERRIDE;
251 virtual void Close() OVERRIDE; 251 virtual void Close() OVERRIDE;
252 virtual void OnCloseStarted() OVERRIDE; 252 virtual void OnCloseStarted() OVERRIDE;
253 virtual void OnUnloadDetachedStarted() OVERRIDE;
253 virtual bool ShouldAcceptDragAndDrop() const OVERRIDE; 254 virtual bool ShouldAcceptDragAndDrop() const OVERRIDE;
254 virtual void SystemDragEnded() OVERRIDE; 255 virtual void SystemDragEnded() OVERRIDE;
255 virtual void UserGestureDone() OVERRIDE; 256 virtual void UserGestureDone() OVERRIDE;
256 virtual void SetClosedByUserGesture(bool value) OVERRIDE; 257 virtual void SetClosedByUserGesture(bool value) OVERRIDE;
257 virtual bool GetClosedByUserGesture() const OVERRIDE; 258 virtual bool GetClosedByUserGesture() const OVERRIDE;
258 virtual double GetZoomLevel() const OVERRIDE; 259 virtual double GetZoomLevel() const OVERRIDE;
259 virtual int GetZoomPercent(bool* enable_increment, 260 virtual int GetZoomPercent(bool* enable_increment,
260 bool* enable_decrement) const OVERRIDE; 261 bool* enable_decrement) const OVERRIDE;
261 virtual void ViewSource() OVERRIDE; 262 virtual void ViewSource() OVERRIDE;
262 virtual void ViewFrameSource(const GURL& url, 263 virtual void ViewFrameSource(const GURL& url,
(...skipping 552 matching lines...) Expand 10 before | Expand all | Expand 10 after
815 816
816 // The time that we started to create the new tab page. 817 // The time that we started to create the new tab page.
817 base::TimeTicks new_tab_start_time_; 818 base::TimeTicks new_tab_start_time_;
818 819
819 // The time that we started to close this WebContents. 820 // The time that we started to close this WebContents.
820 base::TimeTicks close_start_time_; 821 base::TimeTicks close_start_time_;
821 822
822 // The time when onbeforeunload ended. 823 // The time when onbeforeunload ended.
823 base::TimeTicks before_unload_end_time_; 824 base::TimeTicks before_unload_end_time_;
824 825
826 // The time when the tab was removed from view during close.
827 base::TimeTicks unload_detached_start_time_;
828
825 // The time that this tab was last selected. 829 // The time that this tab was last selected.
826 base::TimeTicks last_selected_time_; 830 base::TimeTicks last_selected_time_;
827 831
828 // See description above setter. 832 // See description above setter.
829 bool closed_by_user_gesture_; 833 bool closed_by_user_gesture_;
830 834
831 // Minimum/maximum zoom percent. 835 // Minimum/maximum zoom percent.
832 int minimum_zoom_percent_; 836 int minimum_zoom_percent_;
833 int maximum_zoom_percent_; 837 int maximum_zoom_percent_;
834 // If true, the default zoom limits have been overriden for this tab, in which 838 // If true, the default zoom limits have been overriden for this tab, in which
(...skipping 29 matching lines...) Expand all
864 // All live RenderWidgetHostImpls that are created by this object and may 868 // All live RenderWidgetHostImpls that are created by this object and may
865 // outlive it. 869 // outlive it.
866 std::set<RenderWidgetHostImpl*> created_widgets_; 870 std::set<RenderWidgetHostImpl*> created_widgets_;
867 871
868 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl); 872 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl);
869 }; 873 };
870 874
871 } // namespace content 875 } // namespace content
872 876
873 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 877 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698