Flapper field trial to use workerpool for sync file operations.

chrome/common/chrome_content_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_content_client.h"
 
 #include "base/command_line.h"
 #include "base/cpu.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
@@ skipping 280 matching lines @@
 
   FilePath flash_path;
   if (!PathService::Get(chrome::FILE_PEPPER_FLASH_PLUGIN, &flash_path))
     return false;
 
   bool force_enable = CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableBundledPpapiFlash);
 
   *plugin = CreatePepperFlashInfo(flash_path, FLAPPER_VERSION_STRING);
   *override_npapi_flash = force_enable || IsPepperFlashEnabledByDefault();
+
+  // TODO(shess): http://crbug.com/153383 debugging.

[yzshen1, 2012/10/02 23:33:44]

IIRC, at this point the field trial list hasn't been initialized, right?

That is one of the reasons why we needed to register the component-updated field
trial WinFlapper at a latter stage.

[Scott Hess - ex-Googler, 2012/10/02 23:42:31]

OK - would it make sense to tuck it into ConductingPepperFlashFieldTrial()?  I
was thinking of decoding how to remove all that, but as long as it's still
there, it obviously gets called at the right points.

[yzshen1, 2012/10/02 23:52:10]

I guess not, because ConductingPepperFlashFieldTrial() is called even earlier.
(It doesn't manipulate FieldTrial, it only decides whether the current platform
will be involved in a field trial.)

What do you think about putting it in the creation of PepperFileMessageFilter?

[Scott Hess - ex-Googler, 2012/10/03 19:38:51]

Oops, sorry - I hadn't read this before just moving it to
IsPepperFlashEnabledByDefault(), which is the code which in the past had to have
field trials setup beforehand.

Was going to argue, but I tried your suggestion and it simplified things a lot. 
So not arguing.

Earlier when it was failing browser_tests, it was because field trials weren't
setup.  With this change I see the field trial in place when the code is
executed, so I think it's in the right order.  Same thing with the
IsPepperFlashEnabledByDefault() version, but this version is better.

[yzshen1, 2012/10/03 19:58:36]

Yay!

+  ActivatePepperFlashThreadFieldTrial();
   return true;
 #else
   return false;
 #endif  // FLAPPER_AVAILABLE
 }
 
 #if defined(OS_WIN)
 // Launches the privileged flash broker, used when flash is sandboxed.
 // The broker is the same flash dll, except that it uses a different
 // entrypoint (BrokerMain) and it is hosted in windows' generic surrogate
@@ skipping 230 matching lines @@
 
 bool ChromeContentClient::GetBundledFieldTrialPepperFlash(
     content::PepperPluginInfo* plugin,
     bool* override_npapi_flash) {
   if (!ConductingPepperFlashFieldTrial())
     return false;
   return GetBundledPepperFlash(plugin, override_npapi_flash);
 }
 
 }  // namespace chrome