Implement host side of sync EnumerateVideoCaptureDevices

Implement host side of sync EnumerateVideoCaptureDevices

This implements the host side of the sync ppapi function EnumerateVideoCaptureDevices. 


BUG=none
TEST=Wrote a sample that runs the sync and non-sync versions. Ran it and compared the outputs.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162048

[yzshen1, 2012-10-10 18:17:39]

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/c...
File content/renderer/pepper/content_renderer_pepper_host_factory.cc (right):

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/c...
content/renderer/pepper/content_renderer_pepper_host_factory.cc:49: case
PpapiHostMsg_Flash_Create::ID:
I think it is okay to check PERMISSION_FLASH.

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
File content/renderer/pepper/pepper_flash_host.cc (right):

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
content/renderer/pepper/pepper_flash_host.cc:66:
ppapi::host::ReplyMessageContext reply_message_context,
wrong indent.

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
content/renderer/pepper/pepper_flash_host.cc:72: devices =
enter.object()->GetDeviceRefData();
nit, optional: it seems nice to avoid this copy.

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
File content/renderer/pepper/pepper_flash_host.h (right):

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
content/renderer/pepper/pepper_flash_host.h:19: class CONTENT_EXPORT
PepperFlashHost
Do we need to export it?

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
content/renderer/pepper/pepper_flash_host.h:31: int32_t
OnMsgEnumerateVideoDevicesSync(
Please update the name accordingly.

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
content/renderer/pepper/pepper_flash_host.h:35: void
OnEnumerateVideoDevicesComplete(
Please add 'Capture' to the name.

https://codereview.chromium.org/11016007/diff/14001/ppapi/cpp/private/flash.cc
File ppapi/cpp/private/flash.cc (right):

https://codereview.chromium.org/11016007/diff/14001/ppapi/cpp/private/flash.c...
ppapi/cpp/private/flash.cc:62: if (has_interface<PPB_Flash_12_5>()) {
Haha! Please use 12_6. :)

https://codereview.chromium.org/11016007/diff/14001/ppapi/cpp/private/flash.c...
ppapi/cpp/private/flash.cc:266: return
flash_12_combined_interface.EnumerateVideoDevicesSync(
Please update the function name.

https://codereview.chromium.org/11016007/diff/14001/ppapi/cpp/private/flash.h
File ppapi/cpp/private/flash.h (right):

https://codereview.chromium.org/11016007/diff/14001/ppapi/cpp/private/flash.h...
ppapi/cpp/private/flash.h:69: static int32_t EnumerateVideoDevicesSync(const
InstanceHandle& instance,
Please use the same name as the c interface.

https://codereview.chromium.org/11016007/diff/14001/ppapi/examples/enumerate_...
File ppapi/examples/enumerate_devices/enumerate_devices.cc (right):

https://codereview.chromium.org/11016007/diff/14001/ppapi/examples/enumerate_...
ppapi/examples/enumerate_devices/enumerate_devices.cc:46: virtual void
DidChangeView(const pp::Rect& position,
No need to define it if it is empty.

[raymes, 2012-10-11 18:39:26]

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/c...
File content/renderer/pepper/content_renderer_pepper_host_factory.cc (right):

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/c...
content/renderer/pepper/content_renderer_pepper_host_factory.cc:49: case
PpapiHostMsg_Flash_Create::ID:
On 2012/10/10 18:17:39, yzshen1 wrote:
> I think it is okay to check PERMISSION_FLASH.

Done.

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
File content/renderer/pepper/pepper_flash_host.cc (right):

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
content/renderer/pepper/pepper_flash_host.cc:66:
ppapi::host::ReplyMessageContext reply_message_context,
On 2012/10/10 18:17:39, yzshen1 wrote:
> wrong indent.

Done.

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
content/renderer/pepper/pepper_flash_host.cc:72: devices =
enter.object()->GetDeviceRefData();
On 2012/10/10 18:17:39, yzshen1 wrote:
> nit, optional: it seems nice to avoid this copy.

Done.

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
File content/renderer/pepper/pepper_flash_host.h (right):

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
content/renderer/pepper/pepper_flash_host.h:19: class CONTENT_EXPORT
PepperFlashHost
On 2012/10/10 18:17:39, yzshen1 wrote:
> Do we need to export it?

Done.

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
content/renderer/pepper/pepper_flash_host.h:31: int32_t
OnMsgEnumerateVideoDevicesSync(
On 2012/10/10 18:17:39, yzshen1 wrote:
> Please update the name accordingly.

Done.

https://codereview.chromium.org/11016007/diff/14001/content/renderer/pepper/p...
content/renderer/pepper/pepper_flash_host.h:35: void
OnEnumerateVideoDevicesComplete(
On 2012/10/10 18:17:39, yzshen1 wrote:
> Please add 'Capture' to the name.

Done.

https://codereview.chromium.org/11016007/diff/14001/ppapi/cpp/private/flash.cc
File ppapi/cpp/private/flash.cc (right):

https://codereview.chromium.org/11016007/diff/14001/ppapi/cpp/private/flash.c...
ppapi/cpp/private/flash.cc:62: if (has_interface<PPB_Flash_12_5>()) {
On 2012/10/10 18:17:39, yzshen1 wrote:
> Haha! Please use 12_6. :)

Good catch, thanks.

https://codereview.chromium.org/11016007/diff/14001/ppapi/cpp/private/flash.c...
ppapi/cpp/private/flash.cc:266: return
flash_12_combined_interface.EnumerateVideoDevicesSync(
On 2012/10/10 18:17:39, yzshen1 wrote:
> Please update the function name.

Done.

https://codereview.chromium.org/11016007/diff/14001/ppapi/cpp/private/flash.h
File ppapi/cpp/private/flash.h (right):

https://codereview.chromium.org/11016007/diff/14001/ppapi/cpp/private/flash.h...
ppapi/cpp/private/flash.h:69: static int32_t EnumerateVideoDevicesSync(const
InstanceHandle& instance,
On 2012/10/10 18:17:39, yzshen1 wrote:
> Please use the same name as the c interface.

Done.

https://codereview.chromium.org/11016007/diff/14001/ppapi/examples/enumerate_...
File ppapi/examples/enumerate_devices/enumerate_devices.cc (right):

https://codereview.chromium.org/11016007/diff/14001/ppapi/examples/enumerate_...
ppapi/examples/enumerate_devices/enumerate_devices.cc:46: virtual void
DidChangeView(const pp::Rect& position,
On 2012/10/10 18:17:39, yzshen1 wrote:
> No need to define it if it is empty.

Done.

[yzshen1, 2012-10-12 16:31:10]

lgtm

[commit-bot: I haz the power, 2012-10-12 16:58:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/11016007/19001

[commit-bot: I haz the power, 2012-10-12 16:58:20]

Presubmit check for 11016007-19001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content
    content/renderer

Presubmit checks took 1.2s to calculate.

[raymes, 2012-10-12 16:59:15]

+brettw for OWNERS

[brettw, 2012-10-12 18:01:58]

lgtm

[commit-bot: I haz the power, 2012-10-15 22:59:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/11016007/19001

[commit-bot: I haz the power, 2012-10-16 02:14:14]

Change committed as 162048